1620776 - [meta] Cleanup script flags throughout js frontend

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Unify BaseScript::ImmutableFlags, CompileOptions, and FunctionBox flags. These have subtly different definitions of similar concepts and it very difficult throughout the frontend and vm to know when flags are valid and what the precise definition is.

The objective of this meta-bug would be to use ImmutableFlags as consistently as is reasonable throughout the frontend and clarifying which flags are valid at what points in the process.

Comment 1

[Caroline Cullen [:caroline]]

Attachment: Bug 1620776 - Make ImmutableFlags::HasNonSyntacticScope an input flag. r?tcampbell

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fedd8fbdd5e
Make ImmutableFlags::HasNonSyntacticScope an input flag. r=tcampbell

Comment 3

[Razvan Maries]

Backed out for SM Bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=HKcca65GRBu7r83-4Igrrg-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=7fedd8fbdd5e35b0ee1ea1efd19f31706057d21f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299705890&repo=autoland&lineNumber=46801

Backout: https://hg.mozilla.org/integration/autoland/rev/cdd14a1df784642f8741b0f76041e92ba99ec9df

Comment 4

[Phabricator Automation]

Comment on attachment 9143285 [details]
Bug 1620776 - Make ImmutableFlags::HasNonSyntacticScope an input flag. r?tcampbell

Revision D72491 was moved to bug 1632286. Setting attachment 9143285 [details] to obsolete.