1620834 - provide check if application is an ESR build and not a normal release build

Status: NEW

(Firefox Build System :: General, task)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

From a discussion on Friday:

There are some ESR-specific settings and behaviors but boolean indicating if the application is an ESR built or not.

We don't have something like RELEASE_OR_BETA for ESR, but MOZ_UPDATE_CHANNEL is the wrong thing to use.

It looks like the search service uses AppConstants.MOZ_APP_VERSION_DISPLAY.endsWith("esr")
yeah, that's better albeit not really ideal

Comment 1

[Ricky Stewart]

Is the ask that we basically want a new config variable (e.g. MOZ_IS_ESR) which is equal to MOZ_APP_VERSION_DISPLAY.endsWith("esr")?

Also, are you planning on working on this, or is this a feature request for the build system?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It's a feature request.

From the discussion:

• "We don't have something like RELEASE_OR_BETA for ESR, but MOZ_UPDATE_CHANNEL is the wrong thing to use. Please file a build system bug"
• "It looks like the search service uses AppConstants.MOZ_APP_VERSION_DISPLAY.endsWith("esr")" - "yeah, that's better albeit not really ideal"

MOZ_ESR would be more in line with the other defines.

Comment 3

[Mike Hommey [:glandium]]

For reference, one of the persons in the discussions mentioned in comment 0 and comment 2 is me.