Closed Bug 1620866 Opened 6 years ago Closed 4 years ago

Anonymous style caching doesn't work as it should on mac by default.

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1730503

People

(Reporter: emilio, Unassigned)

References

Details

For disabled and inactive scrollbars (scrollbars when there's no scroll range), this CSS rule breaks scrollbar caching for all the scrollbar elements, unless I'm missing something.

The scrollbar caching code seems very error-prone... :(

Flags: needinfo?(cam)
Priority: -- → P3

In the comment I originally added I wrote regarding non-initial visibility values "don't bother adding this state to the AnonymousContentKey, since it's not so common", but if that's not true, then we can add a bit to handle visibility: hidden on the AnonymousContentKey.

Flags: needinfo?(cam)

Wouldn't be the visibility property we add to the key, but the active / disabled attributes I guess.

I'm curious though why the assertions don't fire given that rule?

Oh it's because it's the top-level scrollbar element that has its visibility set, not some element inside the tree.

Another thing to note is that this whole scroll part style caching mechanism helps with the initial styling (after frame construction), and doesn't kick in when we restyle the scroll parts as their attributes change. And given the way that we do the opacity animations, we can't really handle restyles. So given that, we shouldn't need to look at active (that's only set in response to activity).

Although (and apologies for the stream of consciousness comments!) we also never have disabled set at the time we do the initial styling of scrollbars, since we only set that in ScrollFrameHelper::FinishReflowForScrollbar.

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3

Bug 1730503 will fix this.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.