1620950 - Port Bug 1602561 to Thunderbird: Make PrintUtils.printWindow() act on a BrowsingContext.

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

Port Bug 1602561. Make PrintUtils.printWindow() act on a BrowsingContext.

https://hg.mozilla.org/mozilla-central/rev/c78f989b17befffd3009ce9fea4103a759bbbd71

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1620950_print_broken.patch

Doesn't fix bug 1620314 but with this e.g. compose window can print.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9131845 [details] [diff] [review]
bug1620950_print_broken.patch

Review of attachment 9131845 [details] [diff] [review]:
-----------------------------------------------------------------

When the compose window is opened the first time, printing works but only through `Print Preview`. Directly through `Print...` or CTRL+P it doesn't work. I then also get, when trying again to print directly, this message: `Some printing functionality is not currently available.` Closing the composer and opening it again let me print.

::: mail/components/compose/content/ComposerCommands.js
@@ +2078,5 @@
>    doCommandParams(aCommand, aParams, aRefCon) {},
>  
>    doCommand(aCommand) {
> +    let browser = GetCurrentEditorElement();
> +    PrintUtils.printWindow(browser.browsingContext);

The try/catch here and on the other places are no more needed?

Comment 3

[Magnus Melin [:mkmelin]]

Hmm, it seems it's always working the only for the second time (second opened compose win), but both ways works for me.
I suspect the problems are part of bug 1620314.

I can't imagine the try/catches would be useful. They would only hide potential errors.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9131845 [details] [diff] [review]
bug1620950_print_broken.patch

Review of attachment 9131845 [details] [diff] [review]:
-----------------------------------------------------------------

I would still take this, as it's porting the mentioned bug. Making printing work again is would need this step, even if it's not complete.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9131845 [details] [diff] [review]
bug1620950_print_broken.patch

Okay, as partly fix.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4e300e98f22
Port Bug 1602561. Make PrintUtils.printWindow() act on a BrowsingContext. r=Paenglab