Closed
Bug 1620967
Opened 6 years ago
Closed 6 years ago
Clean up EvaluationSelector component
Categories
(DevTools :: Console, task, P1)
DevTools
Console
Tracking
(firefox76 fixed)
RESOLVED
FIXED
Firefox 76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(2 files)
The component can probably be renamed into EvaluationContextSelector to better convey what it does.
In order to check the thread type, we use string literals, we can probably put them in constants to avoid mistake.
When creating the context list, we're iterating multiple times over the same array, we can probably only loop once.
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•6 years ago
|
||
Depends on D65963
|
|
Assignee | |
Comment 2•6 years ago
|
||
Store and expose thread types in constants, and use those.
Only loop once through the threads.
Depends on D65965
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0323a98d944
Rename EvaluationSelector to EvaluationContextSelector. r=jlast.
https://hg.mozilla.org/integration/autoland/rev/94a56be0026f
Clean up EvaluationContextSelector. r=jlast.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a0323a98d944
https://hg.mozilla.org/mozilla-central/rev/94a56be0026f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in
before you can comment on or make changes to this bug.
Description
•