Closed Bug 1620976 Opened 5 months ago Closed 3 months ago

Create UI for nsClientAuthRememberService

Categories

(Firefox :: Security, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: mbirghan, Assigned: mbirghan)

References

Details

Attachments

(1 file)

Create a UI tab in the certmanager which allows to user to see and delete all non-private decisions saved in nsClientAuthRemember.

Blocks: 634697
Attachment #9131886 - Attachment description: Bug 1620976 - Remember user's client certificate selection across sessions → Bug 1620976 - Create UI for nsClientAuthRememberService

Landing of this patch failed due to:

"We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
applying /tmp/tmpV0K548
security/manager/ssl/nsNSSIOLayer.cpp
Hunk #1 FAILED at 2222.
1 out of 1 hunk FAILED -- saving rejects to file security/manager/ssl/nsNSSIOLayer.cpp.rej
abort: patch command failed: exited with status 256"

:mbirghan, can you please take a look?

Flags: needinfo?(mbirghan)
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36d497fc42c5
Create UI for nsClientAuthRememberService r=keeler,fluent-reviewers,johannh

Backed out changeset 36d497fc42c5 (bug 1620976) for browser_clientAuthRememberService.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=DB2c3x8UQFWtFGHo75tRew-0&fromchange=36d497fc42c5f7ded6408fedc5f5b0a6250bea0e&tochange=146330c06f775ed40ac40b5552d5d7f8c3ffc63e&searchStr=mochitest

Backout link: https://hg.mozilla.org/integration/autoland/rev/76ee165af611a67b00825ab26b895827dc52e694

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302907529&repo=autoland&lineNumber=17183

[task 2020-05-19T13:54:30.307Z] 13:54:30     INFO - TEST-START | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js
[task 2020-05-19T13:54:30.429Z] 13:54:30     INFO - GECKO(8172) | [Parent 8172: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f0769282400 == 17 [pid = 8172] [id = {28e58506-e937-457d-a84b-0b816f8c5d71}]
[task 2020-05-19T13:54:30.430Z] 13:54:30     INFO - GECKO(8172) | [Parent 8172: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 47 (0x7f076f4c06f0) [pid = 8172] [serial = 52] [outer = (nil)]
[task 2020-05-19T13:54:30.431Z] 13:54:30     INFO - GECKO(8172) | [Parent 8172: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 48 (0x7f0769284400) [pid = 8172] [serial = 53] [outer = 0x7f076f4c06f0]
[task 2020-05-19T13:54:30.447Z] 13:54:30     INFO - GECKO(8172) | [Parent 8172, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowOuter.cpp, line 4257
[task 2020-05-19T13:54:30.543Z] 13:54:30     INFO - GECKO(8172) | [Parent 8172, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/checkouts/gecko/layout/base/nsDocumentViewer.cpp, line 2956
[task 2020-05-19T13:54:30.622Z] 13:54:30     INFO - GECKO(8172) | [Child 8687, Main Thread] WARNING: could not set real-time limit at process startup: file /builds/worker/checkouts/gecko/dom/ipc/ContentChild.cpp, line 1640
[task 2020-05-19T13:54:30.638Z] 13:54:30     INFO - GECKO(8172) | [Child 8687: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f11485d8800 == 1 [pid = 8687] [id = {cec43d85-636a-4776-982c-9e5f45a4c94b}]
[task 2020-05-19T13:54:30.659Z] 13:54:30     INFO - GECKO(8172) | [Child 8687: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x7f115e293350) [pid = 8687] [serial = 1] [outer = (nil)]
[task 2020-05-19T13:54:30.659Z] 13:54:30     INFO - GECKO(8172) | [Child 8687: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x7f1142589400) [pid = 8687] [serial = 2] [outer = 0x7f115e293350]
[task 2020-05-19T13:54:30.719Z] 13:54:30     INFO - TEST-INFO | started process screentopng
[task 2020-05-19T13:54:31.111Z] 13:54:31     INFO - TEST-INFO | screentopng: exit 0
[task 2020-05-19T13:54:31.111Z] 13:54:31     INFO - Buffered messages logged at 13:54:30
[task 2020-05-19T13:54:31.111Z] 13:54:31     INFO - Entering test bound testRememberedDecisionsUI
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - TEST-PASS | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js | Should be able to find the test client cert - 
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - TEST-PASS | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js | Should be able to find pgo-ca-all-usages.pem - 
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - TEST-PASS | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js | Should be able to find client-cert-via-intermediate.pem - 
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - Buffered messages finished
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js | Expected rememberedList to only have one item - 0 == 3 - JS frame :: chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js :: testRememberedDecisionsUI :: line 102
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - Stack trace:
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js:testRememberedDecisionsUI:102
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-19T13:54:31.112Z] 13:54:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-19T13:54:31.113Z] 13:54:31     INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js | Expected the rememberedList to have three labels - 0 == 9 - JS frame :: chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js :: testRememberedDecisionsUI :: line 112
[task 2020-05-19T13:54:31.113Z] 13:54:31     INFO - Stack trace:
[task 2020-05-19T13:54:31.113Z] 13:54:31     INFO - chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js:testRememberedDecisionsUI:112
[task 2020-05-19T13:54:31.114Z] 13:54:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-19T13:54:31.114Z] 13:54:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-19T13:54:31.114Z] 13:54:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-19T13:54:31.115Z] 13:54:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-19T13:54:31.116Z] 13:54:31     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-05-19T13:54:31.117Z] 13:54:31     INFO - TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js | Uncaught exception - at chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js:119 - TypeError: can't access property "value", labels[0] is undefined
[task 2020-05-19T13:54:31.118Z] 13:54:31     INFO - Stack trace:
[task 2020-05-19T13:54:31.119Z] 13:54:31     INFO - testRememberedDecisionsUI@chrome://mochitests/content/browser/security/manager/ssl/tests/mochitest/browser/browser_clientAuthRememberService.js:119:16
[task 2020-05-19T13:54:31.119Z] 13:54:31     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-05-19T13:54:31.119Z] 13:54:31     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
...
...
...
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d9a9f180924
Create UI for nsClientAuthRememberService r=keeler,fluent-reviewers,johannh
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Flags: needinfo?(mbirghan)
You need to log in before you can comment on or make changes to this bug.