Closed Bug 1621008 Opened 5 months ago Closed 5 months ago

Add fix-stacks toolchain as dependency for test and build jobs

Categories

(Thunderbird :: Build Config, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: rjl, Assigned: rjl)

Details

Attachments

(1 file, 2 obsolete files)

This will need to be added as a build dependency for the xpcshell self tests that run during a build, and whatever tests that use fix_stacks.py.

Bugs to port:
Bug 1604964
Bug 1604095
Bug 1619837

This is a port of bugs 1604095, 1604964, and 1619837.
Attachment #9133028 - Flags: review?(geoff)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Patch updated to also include fix-stacks toolchains explicitly on xpcshell tests as the
default list is overwritten completely.

This is a port of bugs 1604095, 1604964, and 1619837.
Attachment #9133269 - Flags: review?(geoff)
Attachment #9133028 - Attachment is obsolete: true
Attachment #9133028 - Flags: review?(geoff)
No changes, just rebased without all of the win-cross stuff underneath it.

This is a port of bugs 1604095, 1604964, and 1619837.
Attachment #9133270 - Flags: review?(geoff)
Attachment #9133269 - Attachment is obsolete: true
Attachment #9133269 - Flags: review?(geoff)
Comment on attachment 9133270 [details] [diff] [review]
Add fix-stacks toolchain and make it a dependency for all tests

Review of attachment 9133270 [details] [diff] [review]:
-----------------------------------------------------------------

Just a general comment: I'd find it easier to review things like this if you listed the revisions you're porting as well as the bug numbers.
Attachment #9133270 - Flags: review?(geoff) → review+
Target Milestone: --- → Thunderbird 76.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2895f182a2d0
Add fix-stacks toolchain and make it a dependency for all tests. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

I've backed this out, since the tasks blew up and prevented the tests running, but I'm not convinced this patch is the problem. It's just a convenient way to get the tests running.
https://hg.mozilla.org/comm-central/rev/c2f8d375f79c612fdf285eba5b05c786db10a990

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5abe17fb66ba
Add fix-stacks toolchain and make it a dependency for all tests. r=darktrojan

Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.