1621018 - Move v2 personalization into promise worker

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Scott [:thecount] Downe]

The current state of v2 personalization is still doing quite a bit of JavaScript on the main thread.

This feature is preffed off, and in order to pref it on, we need to move it off the main thread.

We do this by moving it into a promise worker.

https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/PromiseWorker.jsm

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1621018 - Move v2 personalization into promise worker.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1621018 - Move v2 personalization into promise worker.

Comment 3

[Scott [:thecount] Downe]

To test:

1. Create a brand new profile
2. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
3. Open about:newtab#devtools-ds
4. Ensure "show_spocs" is checked
5. Scroll down a bit and click "Enable V2 Personalization"
6. Scroll up and click "Trigger Idle Daily"
7. You should now have all the attachments from remote settings downloaded.
8. Scroll up and click "Expire Cache"
9. Scroll up and click "Trigger System Tick"
10. refresh the browser.
11. Look for a spoc under "spoc data" and click "collapse/open" on any of those spocs.

Expected:
Look for score to be different from item_score this is the easiest way to verify atm.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed840ec54b16
Move v2 personalization into promise worker. r=gvn,jonathankoren,mconley

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ed840ec54b16

Comment 6

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have verified this, using the above steps, on Firefox Nighlty 76.0a1 (Build ID 20200329214909) and obtained the following results:

• clicking on the "Trigger Idle Daily" button => no changes, at least on the visual side; same for "Expire cache" and "Trigger System Tick";
• refresh was made using both "F5" key and "Refresh Cache" from about:newtab#devtools-ds ;
• only 1 row with data is displayed in the "Spoc data" section - clicking on the "collapse/open" button will show same results for "score" and "item_score";
  Is this the expected behavior, to have two different fields: score and item_score with same value or each field to have different values?
  Please let me know if I am missing something out. Thanks!

I've also set the bellow prefs:

• "browser.search.region" to "US"
• "browser.newtabpage.activity-stream.discoverystream.spocs-endpoint" to " https://spocs.getpocket.com/spocs?site=1116390&country=US&region=US-CA"

Comment 7

[Scott [:thecount] Downe]

The values in score and item_score should be different, and yes, you should see both.

I think the reason they are the same is because I suspect in step 10 you refreshed the cache, which would refresh the score too. I updated step 10 to be more clear, so it doesn't get confused with refresh cache.

Hope that helps!

Comment 8

[Valentina Virlics [:vvalentina], Ecosystem QA]

Verified that this was implemented on Firefox Nightly 76.0a1 (Build ID 20200330220101) using Windows 10, Linux Ubuntu 18.04 and Mac 10.15.
The "score" and "item_score" fields are available and have different values.