Closed Bug 1621046 Opened 5 years ago Closed 2 years ago

remove `moz-phab-dev`; instead automatically detect if installed with `pip install --editable`

Categories

(Conduit :: moz-phab, defect, P5)

Product:
Conduit
Component:
moz-phab
Version:
Production
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glob, Assigned: sheehan)

Details

(Keywords: conduit-triaged, good-first-bug)

To avoid Sentry related foodguns we should remove moz-phab-dev; instead automatically detect if installed with pip install --editable

pip has an internal method which detects this, it boils down to detecting if the .egg-link file is a symlink or not.

    for path in [Path(p) for p in sys.path]:
        if (path / "MozPhab.egg-link").is_file():
            is_development = True
            break
    else:
        is_development = False
Keywords: conduit-triaged, good-first-bug
Priority: -- → P5

Hi I am available to try to fix this bug as my first bug, could I be provided more information on how to fix this bug?

Flags: needinfo?(glob)
Flags: needinfo?(glob)

Removed in bug 1799674.

Assignee: nobody → sheehan
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.