Closed Bug 1621081 Opened 5 months ago Closed 3 months ago

[wpt-sync] Sync PR 22145 - Use assert_precondition in test the-input-element/type-change-state.html

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 22145 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22145
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

Use assert_precondition in test the-input-element/type-change-state.html

Use assert_precondition to check if the browser supports both input element types before trying to change the state from one to other.

For example, WebKitGTK and Safari doesn't support several of the input types tested here (like those related to dates). The output of the test its clearer if the precondition its checked before.

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Attached file Notable wpt changes
# CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

## Status Summary

### Firefox
OK  : 1
PASS: 64[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 462[GitHub]
FAIL: 462

### Chrome
OK  : 1
PASS: 446
FAIL: 16

### Safari
OK  : 1
PASS: 60
FAIL: 402

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=af0c374df9cf95578f2929ed4686f97a64cc7b82)
[GitHub PR Head](https://wpt.fyi/results/?sha=c9d9deb26d98b14aa0e1d17e0b51ccfdc912b112&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=c9d9deb26d98b14aa0e1d17e0b51ccfdc912b112&label=pr_base)

## Details

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38fcdb8fde8a
[wpt PR 22145] - Use assert_implements in test the-input-element/type-change-state.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6483fc7ffd41
[wpt PR 22145] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/06bb3722f5d3
[wpt PR 22145] - Use assert_implements in test the-input-element/type-change-state.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8a97b14a89da
[wpt PR 22145] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.