Open Bug 1621169 Opened 5 years ago Updated 2 years ago

Light theme without tabs-in-titlebar has incorrect colors for tab bar on OS X

Categories

(Core :: Graphics, defect, P3)

Desktop
macOS
defect

Tracking

()

Tracking Status
firefox75 --- wontfix
firefox76 --- fix-optional

People

(Reporter: alaskanemily, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

To see the problem, you must be using OS X, with the "light" theme (not default), and have browser.tabs.drawInTitlebar set to false. I am testing with webrender disabled.

The tabs have a flat, light-gray color (I think it's the same as is used when the window is inactive), even when the window has focused.

This seems to have been broken by this commit: https://hg.mozilla.org/mozilla-central/rev/2136aaa9de33705610c8b3b3c441630500b0f2e1

Although given that that is just a backout, I would guess that it had actually been broken before that, and the changes that backed out just hid the problem.

Component: Theme → Graphics: WebRender
Product: Firefox → Core

Emily, does this occur with webrender enabled?

Could you visit about:support, hit "Copy text to clipboard", and attach the results to the bug?

Flags: needinfo?(emcdonough)
Priority: -- → P3

It seems to happen with webrender enabled or disabled.

Attached file about_support

This is from before I enabled webrender to test with.

Flags: needinfo?(emcdonough)
Component: Graphics: WebRender → Graphics

Although this happens with WR too, just blocking on WR-Mac for now so we can decide if we want to fix it for wr on mac later

Blocks: wr-mac

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Priority: P3 → --
Priority: -- → P3

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3

This appears to be fixed both with and without WR with the latest nightly, although when the window doesn't have focus the tabs looks like they have the wrong styling. It seems like tabs aren't getting the inactive style with light theme?

Attached image 89_0a1.png

This looks a bit odd again in 89.0a1 (2021-04-01). I presume this might be related to the issue that made the search and address inputs lose their outlines in light mode?

Are you still able to reproduce this bug?

Flags: needinfo?(emcdonough)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: