1621177 - Two errors are recorded in the EventLog if -log-launcher-error is used

Status: RESOLVED FIXED

(Firefox :: Launcher Process, defect, P3)

Description

[Toshihito Kikuchi [:toshi]]

This is a trivial issue. If we launch firefox.exe with the -log-launcher-error option, we record the same error twice because PostErrorToLog is called in the main thread and the thread which sends a ping.

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 2

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1621177 - post error to Event Log only after telemetry attempt r=tkikuchi

Post a launcher error to the Event Log only after an attempt to send it
via telemetry has concluded, whether in success or in failure.

This implies that the thread which posts the log is:

• in the failure case, whichever thread learns about the failure;
• in the success case, the ping thread, because only it learns about
  success.

(Additionally, check for -- and log -- failure of _beginthreadex.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46ebc949c3af
post error to Event Log only after telemetry attempt r=tkikuchi

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/46ebc949c3af