1621204 - Handle autocomplete popup better it doesn't have enough space at the top of screen

Status: NEW

(DevTools :: Console, enhancement, P3)

Description

[Cristian Fogel, QA [:cfogel]]

Attachment: poppush.png

Affected versions

• 75.0a1 (2020-03-08), 76.0a1 (2020-03-09)

Affected platforms

• Windows 10, macOS 10.15, Ubuntu 18.04

Steps to reproduce

• devtools.webconsole.input.eagerEvaluation set on true;

1. Launch Firefox, enable DevTools, select the Console tab;
2. v1. Dock to left/right and move the browser at the topmost side of screen;
3. v2. With DevTools docked to bottom drag it all the way up & move the browser to the top-side of the screen;
4. Start typing in any expression;

Expected result

• popup is displayed at the top of the expression;

Actual result

• popup is still displayed over the evaluation preview;

Regression range

• not a regression, follow-up from 1609942;

Additional notes

• attached screenshot with the issue;

• As per comment 10 in bug 1609942:

• when the inspector is dragged all the way up and the menu cannot be contained it is displayed as prior to this patch(over the evaluation preview);
• when the DevTools is docked to right/left and the input is on the first rows the menu is displayed over the preview as well, until there is enough space for the menu to be displayed above;
• with DevTools undocked, moving the window all the way up-top the side of the screen causes the same issue;

While this is not a buggy behavior, it might be something that can be improved in the future. A few ideas that come to mind:

• having the menu size adjusted based on the number of entries that would take to fit in the available space;
• having the menu be displayed bellow the preview (but that might be confusing at first).