Closed Bug 1621210 Opened 5 months ago Closed 5 months ago

Cancelled events are not shown as cancelled in "Events and Tasks" bar (Today pane)

Categories

(Calendar :: Calendar Views, defect)

Lightning 68.5.0
x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
68.5.0

People

(Reporter: Cornelius, Assigned: Paenglab)

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

The resolved bug 686420 from 9 years ago is open again:
As the title says events that are cancelled show up in the today pane.

Attached image Cancelled-Event.png

I can reproduce using Thunderbird 68.6.0 on Ubuntu 18.04.4 LTS Linux.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Windows 10 → All

This fixes it for me on ESR.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9134746 - Flags: approval-calendar-esr?(paul)

Trunk is a bit different, also in the day/week calendar view are the line-through not shown. Here we need to use different classes.

Attachment #9134752 - Flags: review?(paul)
Attachment #9134752 - Flags: approval-calendar-beta?(paul)

Forgot to qrefresh.

Attachment #9134752 - Attachment is obsolete: true
Attachment #9134752 - Flags: review?(paul)
Attachment #9134752 - Flags: approval-calendar-beta?(paul)
Attachment #9134754 - Flags: review?(paul)
Attachment #9134754 - Flags: approval-calendar-beta?(paul)
Comment on attachment 9134746 [details] [diff] [review]
1621210-cancelled-line-through-ESR.patch

Review of attachment 9134746 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, changes look fine.
Attachment #9134746 - Flags: approval-calendar-esr?(paul) → approval-calendar-esr+
Comment on attachment 9134754 [details] [diff] [review]
1621210-cancelled-line-through.patch

Review of attachment 9134754 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.  I confirmed that without this patch there is no line through, and with it there is, for both event boxes in the today pane and in the calendar views like week view.
Attachment #9134754 - Flags: review?(paul)
Attachment #9134754 - Flags: review+
Attachment #9134754 - Flags: approval-calendar-beta?(paul)
Attachment #9134754 - Flags: approval-calendar-beta+
Target Milestone: --- → 76

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cbfbee1f4294
Cancelled events don't show the line-through. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: 76 → 75

Milestone is wrong, but there is no 68.7.0 one to set it correctly.

Target Milestone: 75 → 68.5.0
You need to log in before you can comment on or make changes to this bug.