1621210 - Cancelled events are not shown as cancelled in "Events and Tasks" bar (Today pane)

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Cornelius]

The resolved bug 686420 from 9 years ago is open again:
As the title says events that are cancelled show up in the today pane.

Comment 1

[WaltS48 [:walts48]]

Attachment: Cancelled-Event.png

I can reproduce using Thunderbird 68.6.0 on Ubuntu 18.04.4 LTS Linux.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1621210-cancelled-line-through-ESR.patch

This fixes it for me on ESR.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1621210-cancelled-line-through.patch

Trunk is a bit different, also in the day/week calendar view are the line-through not shown. Here we need to use different classes.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1621210-cancelled-line-through.patch

Forgot to qrefresh.

Comment 5

[Paul Morris [:pmorris]]

Comment on attachment 9134746 [details] [diff] [review]
1621210-cancelled-line-through-ESR.patch

Review of attachment 9134746 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, changes look fine.

Comment 6

[Paul Morris [:pmorris]]

Comment on attachment 9134754 [details] [diff] [review]
1621210-cancelled-line-through.patch

Review of attachment 9134754 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.  I confirmed that without this patch there is no line through, and with it there is, for both event boxes in the today pane and in the calendar views like week view.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cbfbee1f4294
Cancelled events don't show the line-through. r=pmorris

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 75.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/70e15738ba2c

Comment 9

[Magnus Melin [:mkmelin]]

Thunderbird 68.7: https://hg.mozilla.org/releases/comm-esr68/rev/fc518fe0390daf5a4af94692f775839bc43b2a00

Comment 10

[Rob Lemley [:rjl]]

Milestone is wrong, but there is no 68.7.0 one to set it correctly.