Closed
Bug 1621210
Opened 5 years ago
Closed 5 years ago
Cancelled events are not shown as cancelled in "Events and Tasks" bar (Today pane)
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
68.5.0
People
(Reporter: Cornelius, Assigned: Paenglab)
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
39.80 KB,
image/png
|
Details | |
1.91 KB,
patch
|
pmorris
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
1.34 KB,
patch
|
pmorris
:
review+
pmorris
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
The resolved bug 686420 from 9 years ago is open again:
As the title says events that are cancelled show up in the today pane.
Comment 1•5 years ago
|
||
I can reproduce using Thunderbird 68.6.0 on Ubuntu 18.04.4 LTS Linux.
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
This fixes it for me on ESR.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9134746 -
Flags: approval-calendar-esr?(paul)
Assignee | ||
Comment 3•5 years ago
|
||
Trunk is a bit different, also in the day/week calendar view are the line-through not shown. Here we need to use different classes.
Attachment #9134752 -
Flags: review?(paul)
Attachment #9134752 -
Flags: approval-calendar-beta?(paul)
Assignee | ||
Comment 4•5 years ago
|
||
Forgot to qrefresh.
Attachment #9134752 -
Attachment is obsolete: true
Attachment #9134752 -
Flags: review?(paul)
Attachment #9134752 -
Flags: approval-calendar-beta?(paul)
Attachment #9134754 -
Flags: review?(paul)
Attachment #9134754 -
Flags: approval-calendar-beta?(paul)
Comment 5•5 years ago
|
||
Comment on attachment 9134746 [details] [diff] [review]
1621210-cancelled-line-through-ESR.patch
Review of attachment 9134746 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, changes look fine.
Attachment #9134746 -
Flags: approval-calendar-esr?(paul) → approval-calendar-esr+
Comment 6•5 years ago
|
||
Comment on attachment 9134754 [details] [diff] [review]
1621210-cancelled-line-through.patch
Review of attachment 9134754 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks. I confirmed that without this patch there is no line through, and with it there is, for both event boxes in the today pane and in the calendar views like week view.
Attachment #9134754 -
Flags: review?(paul)
Attachment #9134754 -
Flags: review+
Attachment #9134754 -
Flags: approval-calendar-beta?(paul)
Attachment #9134754 -
Flags: approval-calendar-beta+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Updated•5 years ago
|
Target Milestone: --- → 76
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cbfbee1f4294
Cancelled events don't show the line-through. r=pmorris
Comment 8•5 years ago
|
||
bugherder uplift |
Thunderbird 75.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/70e15738ba2c
Updated•5 years ago
|
Target Milestone: 76 → 75
Comment 9•5 years ago
|
||
Comment 10•5 years ago
|
||
Milestone is wrong, but there is no 68.7.0 one to set it correctly.
Target Milestone: 75 → 68.5.0
You need to log in
before you can comment on or make changes to this bug.
Description
•