1621256 - Update the GCCellPtr gdb pretty printer

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[André Bargull [:anba]]

The GCCellPtr gdb pretty printer needs to be updated to support the current set of inline trace kinds and it should also be improved to support out-of-line types.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1621256: Update GCCellPtr gdb pretty printer and add support for out-of-line types. r=sfink!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2097f0a5abbb
Update GCCellPtr gdb pretty printer and add support for out-of-line types. r=sfink

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 2097f0a5abbb (Bug 1621256) for spidermonkey bustages CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=292661599

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292661599&repo=autoland&lineNumber=9516

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7516aaa595a0
Backed out changeset 2097f0a5abbb for spidermonkey bustages CLOSED TREE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6218eafa111
Update GCCellPtr gdb pretty printer and add support for out-of-line types. r=sfink

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out changeset e6218eafa111 (bug 1621256) for causing spidermonkey bustages.

Backout revision https://hg.mozilla.org/integration/autoland/rev/bc7d3d129420c43ce29482bd3f320215f0c540d6

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=292725783&resultStatus=testfailed%2Cbusted%2Cexception&revision=e6218eafa1112c29badc2f988469b0ffc89b2c33&searchStr=linux%2Cx64%2Copt%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-package-linux64%2Fopt%2Csm%28pkg%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=292725783&repo=autoland

Andre can you please take another look?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033b7e756564
Update GCCellPtr gdb pretty printer and add support for out-of-line types. r=sfink

Comment 8

[Alexandru Michis [:malexandru]]

Re-landed since it was not the culprit for the failures in Comment 6.
Sorry for the inconvenience!

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/033b7e756564

Comment 10

[Jon Coppeard (:jonco)]

Thank you for doing this.