Closed Bug 1621282 Opened 4 years ago Closed 4 years ago

The CookieJarSettings doesn't sync properly to the WindowContext.

Categories

(Core :: Privacy: Anti-Tracking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: timhuang, Assigned: timhuang)

References

Details

Attachments

(1 file)

The CookieJarSettings doesn't sync to the WindowContext. The reason is that the place where to do the sync is too early that the inner window isn't ready yet. We should find a better place where the inner window and the WindowContext both are ready that we can sync the CookieJarSettings there.

We sync the CookieJarSettings to the WindowContext in
Document::StartDocumentLoad(). This is incorrect because the inner
window haven't been set to the document in
Document::StartDocumentLoad(). So, the CookieJarSettings doesn't be
synced to the WindowContext properly.

This patch fixes this issue by change the place where we do the sync. It
changes it to do the sync at the end of
nsGlobalWindowOuter::SetNewDocument() where the inner window and the
window context are both ready for the document.

Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46f4a21a1624
Fix the issue that CookieJarSettings is not synced to the WindowContext. r=dimi,Ehsan
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: