162129 - Apparent memory leak in COOKIE_Read

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P2)

Description

[otaylor]

I was using Mozilla as a test of my MemProf memory profiler and 
leak detector, and a number of 40 byte leaks were reported in:

  source/extensions/cookie/nsCookies.cpp:COOKIE_Read

(40 bytes is the size of a cookie structure). In a brief read-through
of the code, it looks like the culprit is the code:

1790     /* check for bad legacy cookies (domain not starting with a dot) */
1791     if (new_cookie->isDomain && *new_cookie->host != '.') {
1792       /* bad cookie, discard it */
1793       continue;
1794     }

I believe the cookie (and probably the string it contains) needs to be
freed before continuing, since it is just a pointer to a allocated
structure.

There is also a theoretical memory leak immediately after: in the
case where cookie_list couldn't be allocated, the first cookie needs
to be freed before returning.

Comment 1

[Stephen P. Morse]

Attachment: plug up the two leaks

Comment 2

[jag (Peter Annema)]

Comment on attachment 96884 [details] [diff] [review]
plug up the two leaks

sr=jag

Comment 3

[Samir Gehani]

Comment on attachment 96884 [details] [diff] [review]
plug up the two leaks

r=sgehani

Comment 4

[Stephen P. Morse]

patch checked in

Comment 5

[Tom Everingham]

verified - 09/05/02 tr builds