Closed
Bug 1621311
Opened 4 years ago
Closed 4 years ago
Profiler shortcuts are broken by the recent about:profiling changes
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox-esr68 unaffected, firefox73 unaffected, firefox74 unaffected, firefox75 unaffected, firefox76 fixed)
RESOLVED
FIXED
Firefox 76
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox73 | --- | unaffected |
firefox74 | --- | unaffected |
firefox75 | --- | unaffected |
firefox76 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
I made a change because of some review feedback, and neglected to update some code outside of the performance-new directory. This broke the toggleProfiler function.
Assignee | ||
Comment 1•4 years ago
|
||
This regression fix does not include a test, but I'll try and follow-up with one.
I'd prefer to get this fixed sooner rather than later. I attempted to write a test
for the shortcuts before, and I failed due to some kind of race condition.
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d44b4d633c8 Fix keyboard shortcuts for the profiler; r=canaltinova
Comment 3•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Updated•4 years ago
|
Keywords: regression
Updated•4 years ago
|
status-firefox73:
--- → unaffected
status-firefox74:
--- → unaffected
status-firefox75:
--- → unaffected
status-firefox-esr68:
--- → unaffected
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•