1621357 - [release] Release promotion for Thunderbird 68.6.0 fails due to partials generation scopes

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

There's some extra scopes in Esr68 that are not present on later releases that need to be cleaned up when setting up partial-generation jobs for Thunderbird.

Client ID task-client/cOPvRJS_Q8SyMDNXXFvxNA/0/on/aws/i-0de1db19b419f7954/until/1583858215.502 does not have sufficient scopes and is missing the following scopes:

secrets:get:project/releng/gecko/build/level-3/datadog-api-key

Comment 1

[Rob Lemley [:rjl]]

Attachment: [release] Fix scopes and environment variables in partials jobs

This just removes the scopes and environment variables from the task before
submitting it to Taskcluster. funsize.py itself does not need to have these
set in order to function.

While fixing the Datadog scopes, I noticed that the MAR channel environment
variable would not get set for Thunderbird. Since this patch is intended to
run only on comm-esr68 and will never go elsewhere it's hardcoded.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9132343 [details] [diff] [review]
[release] Fix scopes and environment variables in partials jobs

Review of attachment 9132343 [details] [diff] [review]:
-----------------------------------------------------------------

You can have my r=mkmelin on this if you want.

Comment 3

[Rob Lemley [:rjl]]

Thunderbird 68.6.0:
https://hg.mozilla.org/releases/comm-esr68/rev/5b1af38dba8628ef5ff2c395dc62fb10d52aa012

I need to land a follow-up to fix the f8 extra new-line error.

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9132343 [details] [diff] [review]
[release] Fix scopes and environment variables in partials jobs

That `print(task)` line probably shouldn't be there but it's not going to break anything.

Comment 5

[Rob Lemley [:rjl]]

Follow-up:
https://hg.mozilla.org/releases/comm-esr68/rev/87cc34888d8798c0e4cfce53aeb8678af362a647