1621380 - After calling reject in a onAndroidPermissionsRequest we still get a onMediaPermissionRequest

Status: RESOLVED WORKSFORME

(GeckoView :: Media, defect, P2)

Description

[Manuel Martin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

• Start FxR
• Open https://www.onlinemictest.com/webcam-test/
• Click on the Camera test
• The permission request is displayed
• Click on "Allow"

Actual results:

The app crashes:

android.os.ServiceSpecificException
at android.os.Parcel.readException(Parcel.java:1715)
at android.os.Parcel.readException(Parcel.java:1654)
at android.hardware.ICameraService$Stub$Proxy.connectDevice(ICameraService.java:324)
at android.hardware.camera2.CameraManager.openCameraDeviceUserAsync(CameraManager.java:334)
at android.hardware.camera2.CameraManager.openCameraForUid(CameraManager.java:488)
at android.hardware.camera2.CameraManager.openCamera(CameraManager.java:452)
at org.webrtc.Camera2Session.<init>(Camera2Session.java:42)
at org.webrtc.Camera2Capturer.createCameraSession(Camera2Capturer.java:2)
at org.webrtc.CameraCapturer$5.run(CameraCapturer.java:10)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:173)
at android.os.HandlerThread.run(HandlerThread.java:61)

Expected results:

We shouldn't get a permission request as we are explicitly rejecting the camera permission for platforms that don't have camera support like the Vive Focus Plus or Pico.

We call reject on the onAndroidPermissionsRequest callback but we still get the onMediaPermissionRequest call.

This worked well with 74.0.20200107215758

We are currently using: 75.0.20200304084140

Comment 1

[Eugen Sawin [:esawin]]

I cannot reproduce this with the latest GV. The site calls getUserMedia which prompts for the device permission first and doesn't prompt for the content permission if the former is denied.

Manuel, is this still an issue for you?

Comment 2

[Manuel Martin]

I have tested and this is already fixed in v77. Everything works as expected.

Thanks!

Comment 3

[Manuel Martin]

This seems to have regressed in v79. (79.0.20200625094452) It's crashing again, same STRs.

Comment 4

[Eugen Sawin [:esawin]]

I'm still not able to reproduce this issue with the latest GV.
Maybe I'm testing the wrong scenario?

I've set GVE to reject the onAndroidPermissionsRequest for the camera, which is I think what you do on those devices.
Once the Android permission is rejected, I don't get the onMediaPermissionRequest.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:amoya, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.

Comment 7

[Cathy Lu [:calu]]

Could not reproduce, logs show with no crash:

Web Content: Getting user media failed: NotAllowedError: The request is not allowed by the user agent or the platform in the current context.
GeckoSession: handleMessage: GeckoView:DismissClipboardPermissionRequest