Closed Bug 16214 Opened 25 years ago Closed 25 years ago

Resurrect opaque folder objects rather than use strings

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

All
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dveditz, Assigned: dbragg)

Details

We need to resurrect folder objects rather than use strings.  This means
GetFolder() and GetComponentFolder() need to return objects, and various
install methods need to *take* objects. (AddSubcomponent and AddDirectory in
particular).

The dir... and file... methods will be split into a new object, but they, too
need to be converted to take the new object.
Target Milestone: M11
setting target milestone to m11.
Status: NEW → ASSIGNED
accepting
The GetFolder and GetComponent folder aspects of this bug are done.  The code is
not checked in because the "receivers" need to be modified as well.  So I guess
this is just a status report.
Blocks: 17432
Target Milestone: M11 → M12
Changing to M12.  It's complete for M11 but code reviewers are few and far
between.
Target Milestone: M12 → M11
Don this is a big change (pretty much a semi-rewrite). I'd like to see this get
in for M11.

Please send your diffs to Dan Veditz for code review.  It's best if we get this
change in as soon as we can.
Blocks: 17907
Target Milestone: M11 → M12
Additional changes required after code review, so checkin won't happen today.
Moving off M11 now.  We'll see how it goes tomorrow...
This *really* should go in.  It's the only way to get Mac target folders
working reliably.
Yes, I agree, but we may be running out of time for it... :-(   We'll see if we
can make it today.

Don is working on those additional changes you suggested.  We're hoping he would
be done before noon, and send you the diff again.  In the mean time, Jimmy, Don
and I can start testing his build, and make sure we're okay.

The goal is to get this checked in by 3pm, if we're approved again, since we
missed yesterday's train.
doesn't look like we're going to make it today, by 3pm.

Mac installer is working!!!  YEAH!!!  I think we can let this one slide till
M12.
Implementing this only solves part of the problem unforunately. Libjar needs to
be fixed to support FSSpecs in all file operations. Bug 8136 addresses this.
libreg needs to be changed too. There's some other bug on *that*.

But this one is clearly the first step, and we can go a long way on this one
alone.
Blocks: 18471
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Oops, forgot to close this one.  Eez feexed.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine
Status: RESOLVED → VERIFIED
Build 1999-12-12-09-M12(WIN), 1999-12-13-08-M12(MAC), 1999-12-13-08-M12(LINUX)

Looks good.
No longer blocks: 17432
No longer blocks: 17907
No longer blocks: 18471
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.