1621482 - Retriggers not working from Treeherder interface - only using custom action - retrigger

Status: RESOLVED INVALID

(Tree Management :: Treeherder, defect, P1)

Description

[Daniel Varga [:dvarga]]

It happens on all trees, tested on allizom as well
We first noticed this at 3:19 AM Wednesday, Pacific Time (PT)

Receiving (from network inspector):

{
  "code": "InsufficientScopes",
  "message": "This request requires Taskcluster credentials that satisfy the following scope expression:\n\n```\nhooks:trigger-hook:project-gecko/in-tree-action-3-generic/9353e8f146\n```\n\n---\n\n* method:     triggerHook\n* errorCode:  InsufficientScopes\n* statusCode: 403\n* time:       2020-03-10T22:34:08.121Z",
  "requestInfo": {
    "method": "triggerHook",
    "params": {
      "hookGroupId": "project-gecko",
      "hookId": "in-tree-action-3-generic/9353e8f146"
    },
    "payload": {
      "decision": {
        "action": {
          "cb_name": "retrigger-multiple",
          "description": "Create a clone of the task.",
          "name": "retrigger-multiple",
          "symbol": "rt",
          "taskGroupId": "C-6xrtkfSAS6kIMjvVtXPA",
          "title": "Retrigger"
        },
        "push": {
          "owner": "[e-mail]",
          "pushlog_id": "109715",
          "revision": "5daa3dd7c20c587f377a6d32d13373092ab227b3"
        },
        "repository": {
          "level": "3",
          "project": "autoland",
          "url": "https://hg.mozilla.org/integration/autoland"
        }
      },
      "user": {
        "input": {
          "requests": [
            {
              "tasks": [
                "test-linux64-tsan/opt-mochitest-plain-e10s-2"
              ],
              "times": 1
            }
          ]
        },
        "taskGroupId": "C-6xrtkfSAS6kIMjvVtXPA",
        "taskId": null
      }
    },
    "time": "2020-03-10T22:34:08.121Z"
  }
}

Comment 1

[Cameron Dawson [:camd]]

As sclements had mentioned in channel:
taskid and task are null when retrigger button is clicked. It's in the call to TaskclusterModel.submit DetailsPanel ActionBar

We'll need to fix this to be more like the CustomJobActions code for when Taskcluster does their upgrade next time.

Comment 2

[Sarah Clements [:sclements]]

Per Tom.Prince in the #taskcluster channel, "retrigger-multiple won't have task id, since it is a push action not a task action" so there might not be anything we need to change on our end.

This was a regression cause by the taskcluster deployment, which was rolled back - see bug 1621505.