1621491 - activityLog is not working with some parent API calls

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

I discovered while updating a test addon[1], to test bug 1621219, that tab.hide was not being logged when monitoring a tab hiding addon. Primarily we are not setting "alreadyLogged" correctly in some cases. We also missed some issues with logging for event manager.

Since we have a gsoc thing going on, fixing this now.

[1] https://github.com/mixedpuppy/firefox-activity-log

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1621491 fix activityLog api by passing alreadyLogged where necessary

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81e23d803a81
fix activityLog api by passing alreadyLogged where necessary r=rpl

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 81e23d803a81 for causing failures in test_ext_activityLog.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/32fda46f038f6a024e9cea887106ab25fa593abc

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=0dd184191288d3bcbababfde28af171afbab74a1&test_paths=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fmochitest&fromchange=81e23d803a8105dc7ccf2826987490deaf8c1eb7&selectedJob=293384889

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293385569&repo=autoland&lineNumber=29737

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fca076dea300
fix activityLog api by passing alreadyLogged where necessary r=rpl

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fca076dea300