Closed
Bug 1621587
Opened 4 years ago
Closed 4 years ago
remove external API compatibility functions from nsMsgUtils.h
Categories
(MailNews Core :: Backend, task)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 76.0
People
(Reporter: mkmelin, Assigned: mkmelin)
Details
Attachments
(1 file)
|
80.23 KB,
patch
|
benc
:
review+
|
Details | Diff | Splinter Review |
As noted in bug 1618834, we have some unnecessary external linkage compatibility functions defined. External linkage is dead since a long time ago. This bug is to clean this up. https://searchfox.org/comm-central/rev/c677837b2843f96ef5824e1cfd341e7c6df18c32/mailnews/base/util/nsMsgUtils.h#346-349
|
Assignee | |
Comment 1•4 years ago
|
||
Successful try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=64d638838232cb6bb36177efbca5fea5b9461583
The hg comment says what was done.
Attachment #9132983 -
Flags: review?(benc)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9132983 [details] [diff] [review] bug1621587_msg_ext_cleanup.patch Review of attachment 9132983 [details] [diff] [review]: ----------------------------------------------------------------- All looks good to me, and very satisfying indeed!
Attachment #9132983 -
Flags: review?(benc) → review+
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2891d703d759
remove external API compatibility functions from nsMsgUtils.h. r=benc DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•4 years ago
|
Target Milestone: --- → Thunderbird 76.0
You need to log in
before you can comment on or make changes to this bug.
Description
•