Stencil: Maybe add stack space to Vector types
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: anba, Assigned: tcampbell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
When the whole stencil ground work is done, we should re-evaluate which new Vector types should get a bit of stack allocated space. See bug 1390526 for a previous bug where providing stack allocated space helped for frontend performance.
Searchfox page showing Vector types which don't use any stack space:
https://searchfox.org/mozilla-central/search?q=%5CbVector%3C%5B%5Cw%3A%5D%2B%5C*%3F%3E&case=true®exp=true&path=js%2Fsrc%2Ffrontend
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•4 years ago
|
||
Add reserved space for the inner-function list during lazy parsing. The
various BytecodeSection vectors are quite rare for large JS files so 0 is a
reasonable value, but make it explicit anyways.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
A lot of this was fixed by Bug 1668672 and friends. I'll add a stack reservation for innerFunctionIndicesVector since that comes up in syntax parsing. I wasn't able to measure any impact from this, but it adding 4 * uint32_t to the stack seems like a reasonable tradeoff to cover a lot of cases.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2c83acd0d333 Reserve stack space for Vectors in frontend. r=arai
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•