1621635 - Remove exception and strict property from pageError

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Tom S [:evilpie]]

These properties depend on the JS defines JSREPORT_EXCEPTION and JSREPORT_STRICT, both which we we want to remove.

Comment 1

[Tom S [:evilpie]]

I also just noticed a probably unexpected side-effect of nsIScriptError.errorFlag == 0, the following code will always wrongly produce error: false:
error: !!(pageError.flags & pageError.errorFlag)

I guess we usually check for warning == true first, so this works?

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1621635 - Improve devtools handling of nsIScriptError. r?nchevobbe

Removes "exception" and "script" as those properties are unused outside tests and going away.
Corrected the definition of "error", which was wrong because errorFlag == 0.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9025b5239fa5
Improve devtools handling of nsIScriptError. r=nchevobbe

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9025b5239fa5