1621639 - Firefox 74 not respecting color from GTK theme for awesomebar highlighted entry

Status: RESOLVED INVALID

(Core :: Widget: Gtk, defect)

Description

[michelesr]

Attachment: awesomebar-firefox-74.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Update to Firefox 74 (I'm using dark theme)

Actual results:

The color of the highlighted entry changed from the expected blue from the GTK theme to a lighter blue.

Expected results:

The color shouldn't have changed.

Comment 1

[michelesr]

Attachment: awesomebar-firefox-68-esr.png

How the bar was looking like in Firefox 73 (and Firefox 68 ESR that I used for the screenshot)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Can you try to use mozregression (https://mozilla.github.io/mozregression/) to find a regression range?
Thanks.

Comment 4

[michelesr]

10:59.29 INFO: Last good revision: eb92280a988d3df92486ba7fc5fe9fb94be5d780
10:59.29 INFO: First bad revision: e92e3db3bbb43040c97b789648a7054e590eb3f6
10:59.29 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eb92280a988d3df92486ba7fc5fe9fb94be5d780&tochange=e92e3db3bbb43040c97b789648a7054e590eb3f6

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=eb92280a988d3df92486ba7fc5fe9fb94be5d780&tochange=e92e3db3bbb43040c97b789648a7054e590eb3f6

https://hg.mozilla.org/integration/autoland/rev/e92e3db3bbb43040c97b789648a7054e590eb3f6

https://bugzilla.mozilla.org/show_bug.cgi?id=1612509

Comment 5

[michelesr]

Actually I'm wrong: the urlbar in the dark theme is now using the same color as the one used for GTK menu entries. That contrast confused me, but checking with the color picker confirmed it.

Is the any way to bring back the hardcoded blue by tweaking something in the user profile? I was used to it and this new color looks weird to me if the background is dark (it looks good in the regular theme where the background is white).

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to michelesr from comment #5)

Actually I'm wrong: the urlbar in the dark theme is now using the same color as the one used for GTK menu entries. That contrast confused me, but checking with the color picker confirmed it.

Is the any way to bring back the hardcoded blue by tweaking something in the user profile? I was used to it and this new color looks weird to me if the background is dark (it looks good in the regular theme where the background is white).

I'm sure you can use userContent.css to tweak any color value you want.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Closing as invalid as it's not actually a bug.