1621642 - [meta] Fix failing 'spec' spec-tests

Status: NEW

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Ryan Hunt [:rhunt]]

The following tests from the 'spec' repo are excluded from spec-test imports as they're failing.

align.wast
memory_trap.wast
imports.wast
exports.wast
linking.wast
data.wast
names.wast
utf8-custom-section-id.wast

We should investigate and discover why that is.

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 2

[Lars T Hansen [:lth]]

At a minimum we need to separate junk from important stuff, and file bugs for the important stuff. Here's a link with more comments: https://searchfox.org/mozilla-central/source/js/src/jit-test/etc/wasm/generate-spectests/config.toml

Comment 3

[Yury Delendik (:yury)]

names.wast is failing because we don't handle \0 as valid character in the export name, and not just during parsing. Minimal test to fail

const i = wasmTextToBinary(`(module
  (func)
  (export "" (func 0))
  (export "\\00abc" (func 0))
)`);
new WebAssembly.Module(i);

Do we want to document in config.toml as such and/or open a separate bug to put reference there?

Comment 4

[Ryan Hunt [:rhunt]]

I think filing a bug and blocking this one is best. We don't need a comment in that file if we have a bug open for it.