1621655 - Intermittent devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | media rule should now be matched after responsive mode is active -

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=292677034&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W-WoSr_QRc6Nx8sWcPHdHw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-03-11T13:53:51.063Z] 13:53:51 INFO - TEST-START | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js
[task 2020-03-11T13:53:56.006Z] 13:53:56 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "CHANGE_DISPLAY_PIXEL_RATIO"
[task 2020-03-11T13:53:56.007Z] 13:53:56 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "ADD_VIEWPORT"
[task 2020-03-11T13:53:56.740Z] 13:53:56 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "RESIZE_VIEWPORT"
[task 2020-03-11T13:53:56.837Z] 13:53:56 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "LOAD_DEVICE_LIST_START"
[task 2020-03-11T13:53:56.954Z] 13:53:56 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "RESIZE_VIEWPORT"
[task 2020-03-11T13:53:57.056Z] 13:53:57 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "ADD_DEVICE_TYPE"
[task 2020-03-11T13:53:57.071Z] 13:53:57 INFO - GECKO(4525) | console.log: "[DISPATCH] action type:" "ADD_DEVICE"

[task 2020-03-11T13:53:58.114Z] 13:53:58 INFO - TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | Responsive mode should be active. -
[task 2020-03-11T13:53:58.114Z] 13:53:58 INFO - Buffered messages finished
[task 2020-03-11T13:53:58.115Z] 13:53:58 INFO - TEST-UNEXPECTED-FAIL | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | media rule should now be matched after responsive mode is active -
[task 2020-03-11T13:53:58.116Z] 13:53:58 INFO - Stack trace:
[task 2020-03-11T13:53:58.117Z] 13:53:58 INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - chrome://mochitests/content/browser/devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js:testMediaLink:96
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - chrome://mochitests/content/browser/devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js:null:38
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-03-11T13:53:58.118Z] 13:53:58 INFO - TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | height should be properly set. -
[task 2020-03-11T13:53:58.120Z] 13:53:58 INFO - Closing responsive mode
[task 2020-03-11T13:53:58.121Z] 13:53:58 INFO - Waiting for event: 'off' on [object Object].
[task 2020-03-11T13:53:58.162Z] 13:53:58 INFO - Got event: 'off' on [object Object].
[task 2020-03-11T13:53:58.163Z] 13:53:58 INFO - Wait for media-list-changed events to settle on StyleEditorUI
[task 2020-03-11T13:53:59.328Z] 13:53:59 INFO - TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | Responsive mode should no longer be active. -
[task 2020-03-11T13:53:59.328Z] 13:53:59 INFO - TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | The width condition should now be unmatched -
[task 2020-03-11T13:53:59.328Z] 13:53:59 INFO - TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | The height condition should now be unmatched -
[task 2020-03-11T13:53:59.329Z] 13:53:59 INFO - Leaving test bound
[task 2020-03-11T13:54:00.115Z] 13:54:00 INFO - Removing tab.
[task 2020-03-11T13:54:00.115Z] 13:54:00 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-03-11T13:54:00.171Z] 13:54:00 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-03-11T13:54:00.199Z] 13:54:00 INFO - Tab removed and finished closing
[task 2020-03-11T13:54:00.276Z] 13:54:00 INFO - TEST-PASS | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | The main process DevToolsServer has no pending connection when the test ends -
[task 2020-03-11T13:54:00.296Z] 13:54:00 INFO - GECKO(4525) | MEMORY STAT | vsize 20975633MB | residentFast 1449MB
[task 2020-03-11T13:54:00.297Z] 13:54:00 INFO - TEST-OK | devtools/client/styleeditor/test/browser_styleeditor_media_sidebar_links.js | took 9230ms

Comment 1

[Daniel Varga [:dvarga]]

Micha, can you please take a look at this one? It seems that it started after Bug 1621306 got landed

Retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=Linux%2C18.04%2Cx64%2Casan%2Copt%2CMochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-devtools-chrome-e10s-2%2CM%28dt2%29&tochange=5aeb2757b68f771039e374d9d1419073755b7350&fromchange=72129cde7d7fe8d718ce1836bd5f016dd6808e08&selectedJob=292976999

Comment 2

[Intermittent Failures Robot]

30 failures in 989 pushes (0.03 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 27
• mozilla-central: 3

Platform breakdown:

• linux1804-64-asan: 26
• windows10-64-ccov: 1
• windows10-64: 2
• linux1804-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-12&endday=2020-03-12&tree=all

Comment 3

[Micah [:mtigley] (she/her)]

Sure, will take a look. Thanks!

Comment 4

[Intermittent Failures Robot]

21 failures in 913 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• mozilla-central: 5
• try: 1

Platform breakdown:

• linux1804-64-asan: 17
• windows10-64: 3
• linux1804-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-13&endday=2020-03-13&tree=all

Comment 5

[Intermittent Failures Robot]

77 failures in 5336 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #19 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 62
• mozilla-central: 14
• try: 1

Platform breakdown:

• linux1804-64-asan: 66
• windows10-64: 7
• windows10-64-ccov: 2
• linux1804-64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-09&endday=2020-03-15&tree=all

Comment 6

[Intermittent Failures Robot]

28 failures in 920 pushes (0.03 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 26
• mozilla-central: 2

Platform breakdown:

• linux1804-64-asan: 17
• windows10-64: 9
• windows10-64-ccov: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-16&endday=2020-03-16&tree=all

Comment 7

[Intermittent Failures Robot]

19 failures in 908 pushes (0.021 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 12
• mozilla-central: 4
• try: 3

Platform breakdown:

• linux1804-64-asan: 11
• macosx1014-64-shippable: 5
• windows10-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-18&endday=2020-03-18&tree=all

Comment 8

[Intermittent Failures Robot]

55 failures in 935 pushes (0.059 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 50
• mozilla-central: 4
• try: 1

Platform breakdown:

• linux1804-64-asan: 13
• windows10-64: 41
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-19&endday=2020-03-19&tree=all

Comment 9

[Cosmin Sabou [:CosminS]]

Micah, any updates on this? It has reached the disable recommend bugs list with 193 total failures since it was filed on 11th of march: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-02-19&endday=2020-03-20&tree=trunk&bug=1621655
The test will be disabled in the next couple of days if there is no patch for it. Thank you.

Comment 10

[Intermittent Failures Robot]

39 failures in 863 pushes (0.045 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 32
• mozilla-central: 4
• try: 3

Platform breakdown:

• windows10-64: 25
• linux1804-64-asan: 14

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-20&endday=2020-03-20&tree=all

Comment 11

[Razvan Maries]

Attachment: Bug 1621655 - Disabled browser_styleeditor_media_sidebar_links.js on debug/asan for frequent failures. r=jmaher

Comment 12

[Intermittent Failures Robot]

19 failures in 238 pushes (0.08 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 16
• mozilla-central: 2
• try: 1

Platform breakdown:

• windows10-64: 7
• linux1804-64-asan: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-21&endday=2020-03-21&tree=all

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4376c20fd09e
Disabled browser_styleeditor_media_sidebar_links.js on debug/asan for frequent failures. r=jmaher

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4376c20fd09e

Comment 15

[Intermittent Failures Robot]

176 failures in 4955 pushes (0.036 failures/push) were associated with this bug in the last 7 days.

This is the #5 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 147
• mozilla-central: 20
• try: 9

Platform breakdown:

• linux1804-64-asan: 77
• windows10-64: 89
• windows10-64-ccov: 2
• macosx1014-64-shippable: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-16&endday=2020-03-22&tree=all

Comment 16

[Micah [:mtigley] (she/her)]

Recently landed a fix affecting this test in Bug 1624889 that may have also resolved this. I've pushed to try-server with this test enabled at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9494560d619944d7515ce32825604326747d1552

Comment 17

[Micah [:mtigley] (she/her)]

Attachment: Bug 1621655 - Re-enable browser_styleeditor_media_sidebar_links.js on debug/asan builds

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bb4759349e9
Re-enable browser_styleeditor_media_sidebar_links.js on debug/asan builds  r=bradwerth

Comment 19

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7bb4759349e9

Comment 20

[Intermittent Failures Robot]

10 failures in 4773 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• try: 3
• mozilla-central: 4

Platform breakdown:

• macosx1014-64-shippable: 2
• windows10-64: 1
• linux1804-64-ccov: 2
• windows10-64-ccov: 1
• macosx1014-64: 2
• linux1804-64-asan: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-23&endday=2020-03-29&tree=all

Comment 21

[Intermittent Failures Robot]

6 failures in 5015 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• try: 1

Platform breakdown:

• macosx1014-64: 5
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-03-30&endday=2020-04-05&tree=all

Comment 22

[Intermittent Failures Robot]

3 failures in 4823 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform breakdown:

• macosx1014-64-shippable: 1
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 23

[Micah [:mtigley] (she/her)]

Unassigning myself from this for now since I'm not actively working on it.

Comment 24

[Intermittent Failures Robot]

4 failures in 4528 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 1

Platform breakdown:

• macosx1014-64: 2
• macosx1014-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-04-13&endday=2020-04-19&tree=all

Comment 25

[Intermittent Failures Robot]

6 failures in 5582 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 1

Platform breakdown:

• macosx1014-64-shippable: 4
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-04-20&endday=2020-04-26&tree=all

Comment 26

[Intermittent Failures Robot]

6 failures in 5423 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6

Platform breakdown:

• macosx1014-64-shippable: 4
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-04-27&endday=2020-05-03&tree=all

Comment 27

[Intermittent Failures Robot]

7 failures in 5276 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7

Platform breakdown:

• macosx1014-64: 3
• macosx1014-64-shippable: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-05-04&endday=2020-05-10&tree=all

Comment 28

[Intermittent Failures Robot]

14 failures in 5488 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 12
• try: 1
• mozilla-central: 1

Platform breakdown:

• macosx1014-64: 11
• macosx1014-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-05-11&endday=2020-05-17&tree=all

Comment 29

[Intermittent Failures Robot]

5 failures in 4727 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4
• try: 1

Platform breakdown:

• macosx1014-64-shippable: 1
• macosx1014-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-05-18&endday=2020-05-24&tree=all

Comment 30

[Intermittent Failures Robot]

3 failures in 5458 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• try: 1

Platform breakdown:

• macosx1014-64: 2
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-05-25&endday=2020-05-31&tree=all

Comment 31

[Intermittent Failures Robot]

4 failures in 4949 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1
• autoland: 3

Platform breakdown:

• macosx1014-64-devedition: 1
• macosx1014-64-shippable: 2
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 32

[Intermittent Failures Robot]

2 failures in 5211 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• macosx1014-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-06-08&endday=2020-06-14&tree=all

Comment 33

[Intermittent Failures Robot]

5 failures in 4035 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 2
• autoland: 3

Platform breakdown:

• macosx1014-64-devedition: 2
• macosx1014-64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-06-15&endday=2020-06-21&tree=all

Comment 34

[Intermittent Failures Robot]

7 failures in 5252 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• try: 2

Platform breakdown:

• macosx1014-64: 4
• macosx1014-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-06-22&endday=2020-06-28&tree=all

Comment 35

[Intermittent Failures Robot]

8 failures in 4516 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-beta: 1
• mozilla-central: 2

Platform breakdown:

• macosx1014-64-shippable: 7
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-06-29&endday=2020-07-05&tree=all

Comment 36

[Intermittent Failures Robot]

9 failures in 5265 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-beta: 3
• mozilla-central: 1

Platform breakdown:

• macosx1014-64: 4
• macosx1014-64-shippable: 4
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-07-06&endday=2020-07-12&tree=all

Comment 37

[Intermittent Failures Robot]

9 failures in 4014 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-beta: 1

Platform breakdown:

• macosx1014-64: 4
• macosx1014-64-shippable: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-07-13&endday=2020-07-19&tree=all

Comment 38

[Intermittent Failures Robot]

7 failures in 4310 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• try: 1

Platform breakdown:

• macosx1014-64: 4
• macosx1014-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-07-20&endday=2020-07-26&tree=all

Comment 39

[Joel Maher ( :jmaher ) (UTC -8)]

I am seeing this failing consistently on try server when testing with a different resolution (1280x1024 vs 1600x1200). I see this fails shortly after a content-resize and then the media rules are not matching. I suspect this is due to a browser size issue.

:gl, can you help me find someone who can help fix this to work in 1280x1024 screen resolution?

Comment 40

[Brad Werth [:bradwerth]]

I'll try again to find a fix for this. The first attempt clearly didn't work. Thanks for the detective work to determine that it has something to do with the resolution. That's incredibly helpful. Is there a way for me to run the test locally at different resolutions? I don't see a command line option with mochitest that appears to be relevant.

Comment 41

[Joel Maher ( :jmaher ) (UTC -8)]

I only found this out with testing on different osx machines:
./mach try fuzzy --worker-suffix t-osx-1014=-staging ...

you are welcome to use that pool, there are 10 machines and they are used periodically

Comment 42

[Intermittent Failures Robot]

2 failures in 4289 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621655&startday=2020-07-27&endday=2020-08-02&tree=all

Comment 43

[Brad Werth [:bradwerth]]

Attachment: Bug 1621655: Make browser_styleeditor_media_sidebar_links.js test await RDM content reflow.

Comment 44

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80c7772359da3f6c7277768f592ca932e1d36826

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60c96f9da664
Make browser_styleeditor_media_sidebar_links.js test await RDM content reflow. r=rcaliman

Comment 46

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/60c96f9da664

Comment 47

[Brad Werth [:bradwerth]]

This appears to be fixed. I'm not sure if I should close the bug. I'll let ccoroiu decide.

Comment 48

[Cosmin Sabou [:CosminS]]

No failures since it was merged to central, it's fixed. Removing leave-open and adding appropriate flags.