Closed Bug 1621718 Opened 7 months ago Closed 6 months ago

Handled quoted-printable names in import-pr command

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

https://hg.mozilla.org/integration/autoland/rev/ab8746bb808719748e77de3d8ba538574bceee8c was imported using the ./mach import-pr tool, but it botched the commit author name. It scrapes the patch file that github generates, which is mail-ready and therefore escapes non-ASCII content in the headers (and maybe even the body, dunno). We would need to run it through a decoder before generating the gecko-side commit.

(Taking a stab at a better component than Core: General which we try to keep as empty as possible)

Product: Core → Firefox Build System

Thanks. I just used the bugzilla component associated with the tools/vcs/mach_commands.py file but I guess we should update that to Firefox Build System. I can file another bug for that.

This uses the email crate to parse the .patch file that Github generates,
so that it properly decodes encoded-words in the headers. Also using this
crate is better with python3, so this patch also takes the command off the
python2 whitelist and makes it python3-compatible.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b12fa322e5d
Use proper email parsing library for parsing patches. r=ahal
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.