1621913 - [flatpak] the default browser detection doesn't work

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

:Mikaela reported this bug on on Matrix with the following comment which I think is very easy to notice, but it may be me using i3 that breaks it

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

This is now fixed, courtesy to https://hg.mozilla.org/releases/mozilla-beta/rev/b0462a387ec59960985a1d351007dd8ceb548e6d#l2.8 that landed last week. Please feel free to re-open should this is still broken.

Comment 2

[Aminda Suomalainen]

It seems that setting default browser works now, but in about Preferences I still see ":( Firefox ei ole järjestelmän oletusselain" (Firefox is not the default browser of the system) and I see the "set as default" button.

What I have done is launch with org.mozilla.firefox --ProfileManager and checked to always open profile manager (or was it to not start profile by default without asking), opened the settings and seen this.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Found in triaging. Going forward, Flatpak-related bugs will no longer be filed under RelEng, but instead in Core/Widget:GTK where folks have much more in-depth knowledge on this. If the issues are RelEng related, they can be filed against Release Engineering :: Release Automation: Other and we'll take care of that.

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Found in triaging, returning to pool as I'm not actively working on this.

Comment 6

[Jan Horak [:jhorak]]

Currently the chromium does not have a fix for this. Instead it shows:
Chromium cannot determine or set the default browser
Which is fair enough. Currently there's no flatpak portal to set the default browser (I doubt there will be any) or show the system dialog. What we could probably do is to hide the setting of default browser completely in flatpak.

Comment 7

[Jan Grulich]

Relevant upstream issue: https://github.com/flatpak/xdg-desktop-portal/issues/472

Comment 8

[Jan Horak [:jhorak]]

(In reply to grulja from comment #7)

Relevant upstream issue: https://github.com/flatpak/xdg-desktop-portal/issues/472

I'm afraid this is not related, this bug is that Firefox check whenever it is default browser and asks user to set it as default if it isn't (only if the check is allowed).

Comment 9

[Jan Horak [:jhorak]]

Attachment: Bug 1621913 Don't show the defaultBrowserBox in settings under flatpak; r=mkaply

Under Flatpak we cannot determine if the application is set as default handler
for http/https protocols and also the application cannot set the system defaults.
In order to avoid user confusion we hide the defaultBrowserBox which
under flatpak shows always: "Firefox is not your default browser" and the
"Make Default..." button does not make any change to the system.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce8163ab10a4
Don't show the defaultBrowserBox in settings under flatpak; r=settings-reviewers,Gijs

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ce8163ab10a4

Comment 12

[Ina Popescu, Desktop QA]

Attachment: flatpak_settings.png

I've reproduced the issue using Firefox Flatpak 111.0.1 on Ubuntu 22.04.
The issue is no longer reproducible on Firefox Flatpak 112.0 on the same system where the option "Always check if Firefox is your default browser" and the Make Default... button are hidden in Settings.