Open Bug 1621920 Opened 1 year ago Updated 6 months ago

Ignore unknown directories in client directories during temporary storage initialization

Categories

(Core :: Storage: Quota Manager, task, P2)

task

Tracking

()

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(8 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

This may not be an issue, it seems IndexedDB now has some code to handle this, but we should verify it and add tests for that at least.

Assignee: nobody → jvarga
Severity: normal → S3
Keywords: leave-open
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3e3a090ee96
Fix some comments in test_unknownFiles.js; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/b85b0e346dee
Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg
https://hg.mozilla.org/integration/autoland/rev/6d94049a8f9e
Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a85e35f30940
Fix some comments in test_unknownFiles.js; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/41ed069650bb
Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg
https://hg.mozilla.org/integration/autoland/rev/8d4ed3699274
Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d509ac323757
Simplify handling of unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/e92c2d9d3f63
Convert some macros in dom/localstorage/ActorsParent.cpp to literal strings; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/e617cb5af9c8
Polish directory traversal done by LS client; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/006b4e7cf0e4
Convert SDB client to use the new macro for warning about unknown stuff and add handling of unknown directories in SDB client directory; r=dom-workers-and-storage-reviewers,sg
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6bc9dbd575dc
Polish directory traversal done by SDB client; r=dom-workers-and-storage-reviewers,sg

Is the leave-open flag still needed here?

Only LS and SDB quota client have been checked and only LS and SDB have new tests for this:
https://searchfox.org/mozilla-central/rev/7b40f0b246ad0b54975b1525811f2ad599b95f33/dom/quota/test/xpcshell/make_unknownFiles.js#143
vs
https://searchfox.org/mozilla-central/rev/7b40f0b246ad0b54975b1525811f2ad599b95f33/dom/quota/test/xpcshell/make_unknownFiles.js#71

So IDB and CACHE need to be checked. The use of UNKNOWN_FILE_WARNING macro should be replaced with the new one WARN_IF_FILE_IS_UNKNOWN while we are there. I also remember that CACHE wasn't using a macro at all, that should be fixed too.

Regarding the priorities, this should be finished after the asynchronous init work, the new detailed telemetry and probably also about:storage.

Flags: needinfo?(jvarga)

This is sort of work on "improved testing" as well.

You need to log in before you can comment on or make changes to this bug.