1621920 - Ignore unknown directories in client directories during temporary storage initialization

Status: NEW

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

This may not be an issue, it seems IndexedDB now has some code to handle this, but we should verify it and add tests for that at least.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Fix some comments in test_unknownFiles.js; r=#dom-workers-and-storage-reviewers

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Provide a new testable macro for warning about unknown files or directories; r=#dom-workers-and-storage-reviewers

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=#dom-workers-and-storage-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e3a090ee96
Fix some comments in test_unknownFiles.js; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/b85b0e346dee
Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg
https://hg.mozilla.org/integration/autoland/rev/6d94049a8f9e
Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on ActorsParent.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/590bbddc02bd7509657153bbc7a4f2156f35a64e
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307484243&repo=autoland&lineNumber=36704

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a85e35f30940
Fix some comments in test_unknownFiles.js; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/41ed069650bb
Provide a new testable macro for warning about unknown files or directories; r=dom-workers-and-storage-reviewers,ttung,sg
https://hg.mozilla.org/integration/autoland/rev/8d4ed3699274
Convert LS client to use the new macro for warning about unknown stuff and add testing for unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a85e35f30940
https://hg.mozilla.org/mozilla-central/rev/41ed069650bb
https://hg.mozilla.org/mozilla-central/rev/8d4ed3699274

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Simplify handling of unknown directories in LS client directory; r=#dom-workers-and-storage-reviewers

Comment 9

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Convert some macros in dom/localstorage/ActorsParent.cpp to literal strings; r=#dom-workers-and-storage-reviewers

Depends on D81686

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Polish directory traversal done by LS client; r=#dom-workers-and-storage-reviewers

Depends on D81688

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Convert SDB client to use the new macro for warning about unknown stuff and add handling of unknown directories in SDB client directory; r=#dom-workers-and-storage-reviewers

Depends on D81689

Comment 12

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Polish directory traversal done by SDB client; r=#dom-workers-and-storage-reviewers

Depends on D81690

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d509ac323757
Simplify handling of unknown directories in LS client directory; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/e92c2d9d3f63
Convert some macros in dom/localstorage/ActorsParent.cpp to literal strings; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/e617cb5af9c8
Polish directory traversal done by LS client; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/006b4e7cf0e4
Convert SDB client to use the new macro for warning about unknown stuff and add handling of unknown directories in SDB client directory; r=dom-workers-and-storage-reviewers,sg

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bc9dbd575dc
Polish directory traversal done by SDB client; r=dom-workers-and-storage-reviewers,sg

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d509ac323757
https://hg.mozilla.org/mozilla-central/rev/e92c2d9d3f63
https://hg.mozilla.org/mozilla-central/rev/e617cb5af9c8
https://hg.mozilla.org/mozilla-central/rev/006b4e7cf0e4

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6bc9dbd575dc

Comment 17

[Jens Stutte [:jstutte]]

Is the leave-open flag still needed here?

Comment 18

[Jan Varga [:janv]]

Only LS and SDB quota client have been checked and only LS and SDB have new tests for this:
https://searchfox.org/mozilla-central/rev/7b40f0b246ad0b54975b1525811f2ad599b95f33/dom/quota/test/xpcshell/make_unknownFiles.js#143
vs
https://searchfox.org/mozilla-central/rev/7b40f0b246ad0b54975b1525811f2ad599b95f33/dom/quota/test/xpcshell/make_unknownFiles.js#71

So IDB and CACHE need to be checked. The use of UNKNOWN_FILE_WARNING macro should be replaced with the new one WARN_IF_FILE_IS_UNKNOWN while we are there. I also remember that CACHE wasn't using a macro at all, that should be fixed too.

Regarding the priorities, this should be finished after the asynchronous init work, the new detailed telemetry and probably also about:storage.

Comment 19

[Jan Varga [:janv]]

This is sort of work on "improved testing" as well.

Comment 20

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Comment 21

[Jan Varga [:janv]]

Attachment: Bug 1621920 - Convert IDB client to use the new macro for warning about unknown stuff in .files directory and add handling of unknown directories in .files directory; r=#dom-storage

Depends on D119496

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd665848819c
Convert IDB client to use the new macro for warning about unknown stuff in .files directory and add handling of unknown directories in .files directory; r=dom-storage-reviewers,asuth

Comment 23

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cd665848819c

Comment 24

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Comment 25

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:edenchuang, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 26

[Jens Stutte [:jstutte]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #25)

:edenchuang, maybe it's time to close this bug?

No.