DOCTYPE should include system identifier

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Interface
--
trivial
RESOLVED FIXED
15 years ago
5 years ago

People

(Reporter: Tobias Burnus, Assigned: Max Kanat-Alexander)

Tracking

2.17
Bugzilla 2.20
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

15 years ago
The current DOCTYPE causes Mozilla to use the quirks mode. Adding the system
identifier it would render in "Almost Standards Mode" (see URL).
Additional it is good habit to include the URL to the DTD file anyway.
Patch to come.
(Reporter)

Comment 1

15 years ago
Created attachment 94847 [details] [diff] [review]
Add system identifier to the DOCTYPE in global/header.html.tmpl
(Reporter)

Updated

15 years ago
Target Milestone: --- → Bugzilla 2.18
Version: unspecified → 2.17
I applied this locally, and the only differences in layout I noticed were:

a) The index page (the default one, not the one on bmo) has an extra line before
the "Bugzilla Main Page" text. Personally, I think it looks a bit better that way

b) theres an extra blank line in the bottom 'useful-links' table, after the
named queries. I'm guessing that this is due to the nested table/forms, but I'm
not sure.

I wonder if we should also add a default .htaccess for the mime type in /css/,
just to prevent bugs being filed about this in the future.

I also don't know if the hacked up code in edit* can withstand strict mode,
although there weren't problems when I looked quickly.
those differecnes are due to the "Quirk: collapse top margin of BODY and TD and
bottom margin of TD", btw

Is there a better way to 'fix' it than adding a |margin-bottom: 0| rule to that
table?
Why are we doing this? More particularly, why now?

When templatisation is finished, it'll be much easier to do all the HTML 4.01
DOCTYPE etc. purist stuff. In the mean time, we are legacy HTML, and that's what
quirks mode is _for_.

It just seems we are doing it for the sake of it.

Gerv
Well, quirks mode + html transitional mode are not the same thing. And if we do
add it now, then its easier to find any bugs in our html.
I am assigning all the bugs I am not working on in the immediate future to
nobody@bugzilla.org. This means:

- I will be able to search for bugs assigned to me as a list of bugs I'm going
to fix (which is as it should be), and
- people won't falsely assume I might be about to fix a bug when I'm not.

Gerv
Assignee: gerv → nobody

Comment 7

15 years ago
Just $.02 worth from a non-programming end-user of Bugzilla...
Changing the DOCTYPE declaration won't change the fact that this is terrible
HTML code.  I think that should be addressed, because one of the big ideas
behind the Mozilla project is standards-compliance.  It seems to me the reason
for that is to get rid of the "well it looks alright, so it must be fine" attitude.
Now I will go file a bug under the "Tech Evangelism" product, because I know
that somebody will want to tell me that's where this belongs.
What bits of bugzilla are terrible html? Last I checked, we validated on almost
everything except for some of the admin pages which hanve't been templatised yet.

(The wrap attribute on the show_bug textfield doesnt' validate, but I think that
thats about it)

Comment 9

14 years ago
nobody@bugzilla.org cares about these poor bugs and they haven't been touched in
nearly 2 months.  No way they'll hit 2.18 unless something changes.  --> 2.20
If someone adopts them, they can pull them back in.
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20

Comment 10

14 years ago
to comment 9
> nobody@bugzilla.org cares about these poor bugs and they haven't been > touched in
nearly 2 months. 

I don't think this bug is so POOR for what it says, from web standards compliant
point of view. Definitely POOR for that it is not touched for 2 months+ though.
... Commenting to post more than one year ago... 

but why Bugzilla is still Transitional? Strict is much better for its style and
its backword compatibility (if I ommit N4-). mozilla.org and bugzilla.org are
using Strict.
(Assignee)

Comment 11

13 years ago
You know, actually, I think this is a fine idea.
Assignee: nobody → mkanat
(Assignee)

Comment 12

13 years ago
Created attachment 176355 [details] [diff] [review]
Add URL to DOCTYPE (fix bitrot)

I think we ought to render in standards mode. It makes things more consistent
across IE and Gecko, anyhow.
Attachment #94847 - Attachment is obsolete: true
Attachment #176355 - Flags: review?(justdave)

Comment 13

13 years ago
Why not strict?
(Assignee)

Comment 14

13 years ago
(In reply to comment #13)
> Why not strict?

  That's two changes. This is one bug.
(Assignee)

Comment 15

13 years ago
Created attachment 176361 [details] [diff] [review]
Just This Patch (Add URL to DOCTYPE)

Previous patch had another patch in it.
Attachment #176355 - Attachment is obsolete: true
Attachment #176361 - Flags: review?(justdave)
(Assignee)

Updated

13 years ago
Attachment #176355 - Flags: review?(justdave)
Attachment #176361 - Flags: review?(justdave) → review+
Flags: approval+

Comment 16

13 years ago
I think we want to change rendering mode only once. Transitional triggers
"Almost Standards Mode" and Strict triggers "Full Standards Mode".

See <http://www.mozilla.org/docs/web-developer/quirks/doctypes.html>.
(Assignee)

Comment 17

13 years ago
(In reply to comment #16)
> I think we want to change rendering mode only once. Transitional triggers
> "Almost Standards Mode" and Strict triggers "Full Standards Mode".
> 
> See <http://www.mozilla.org/docs/web-developer/quirks/doctypes.html>.

  The Bugzilla development team has worked toward Transitional for many years,
now. We validate as Transitional. If you'd like us to start validating as
Strict, then please file a bug for that. It would be more work than just
changing the DOCTYPE, I believe.

  You can see the developers guide for details:
http://www.bugzilla.org/docs/developer.html#templates in the "Web Technologies"
section.
(Assignee)

Comment 18

13 years ago
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.38; previous revision: 1.37
done
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.