1621953 - Chat button in tab toolbar has no disabled appearance

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: Screenshot of chat button

The chat button in my toolbar doesn't seem to work. Clicking it does nothing. Clicking the calendar icon (to the right of it) brings up the calendar tab.

There's no errors in the console or anything else.

This is with 75b1, but I think it was broke in 74 also.

Comment 1

[Jorg K (CEST = GMT+2)]

So how do people open the chat then? EDIT: I mean, looking at chat is part of testing. And we had chat broken on Mac for a while during TB 74 beta.

Comment 2

[Patrick Cloke [:clokep]]

(In reply to Jorg K (GMT+1) from comment #1)

So how do people open the chat then? EDIT: I mean, looking at chat is part of testing. And we had chat broken on Mac for a while during TB 74 beta.

For me...I always leave the chat tab open so it is always just there.

It is also possible that I've customized / moved buttons or something and that has broken it. I find that to probably be unlikely though.

Comment 3

[Patrick Cloke [:clokep]]

Magnus -- could we get someone to look at this?

Comment 4

[Magnus Melin [:mkmelin]]

Seems WFM for me, at least on trunk but also a 75a1 from 10 days back I tested. Tested linux. Could it be mac only?

Comment 5

[Jorg K (CEST = GMT+2)]

Hmm, well, on Windows in TB 75 beta 1 the chat button opens the chat tab. I could also connect to Freenode's chat (since Mozilla's IRC is down).

Comment 6

[Patrick Cloke [:clokep]]

Ah, there's more to this that I didn't notice. It seems to work fine unless you're on the calendar tab.

Comment 7

[Jorg K (CEST = GMT+2)]

Hmm, when you're on the Calendar tab, there is no chat button by default that you can click.

Comment 8

[Richard Marti (:Paenglab)]

When the main tab isn't active the Chat button is disabled. Something I already noted since long time. It's not visible when the button is in the main toolbar but, like I have too, when it's in the tab bar it's visible. Unfortunately because it's a badge-button the disable rule doesn't work on Mac.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1621953-disabled-button.patch

Removed the direct children selector > to let the rule apply also on badge-button toolbarbuttons which have additional layers. This is a Mac only issue.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1621953-disabled-button-ESR.patch

The same patch but for ESR.

Comment 11

[Patrick Cloke [:clokep]]

Richard -- first, thank you for taking a look at this! Do you know if this has always been an issue or did it regress at some point? (Feel free to rename this bug if I was wrong in the title!)

Comment 12

[Richard Marti (:Paenglab)]

I can't say when this regressed. Maybe when the button was changed to a badge-button.

Comment 13

[Alessandro Castellani [:aleca]]

Comment on attachment 9133621 [details] [diff] [review]
1621953-disabled-button.patch

Review of attachment 9133621 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine as it disables the calendar button when necessary.
We might land this to quickly fix this issue, but the real issue is "why the chat button doesn't work when not in the main tab?"
Is there any technical reason behind the decision of not allowing users to access the chat if not from the main tab?
Maybe I'm missing something obvious, but it seems odd.

Comment 14

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #13)

We might land this to quickly fix this issue, but the real issue is "why the
chat button doesn't work when not in the main tab?"
It works when not in the main toolbar. The button disables when switching away from main tab. I asked a long time ago how to fix and found no solution. If you find it, great.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eb262dce2275
Remove a direct children selector on the disabled toolbarbutton rule to make the chat button in tab toolbar look properly disabled. r=aleca DONTBUILD

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 75.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/6624c6d87c4f

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9133622 [details] [diff] [review]
1621953-disabled-button-ESR.patch

Approved for ESR

Comment 18

[Magnus Melin [:mkmelin]]

Thunderbird 68.7: https://hg.mozilla.org/releases/comm-esr68/rev/c818183a870f552bbccf0c95ace002e70187072b