Closed Bug 1622070 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22225 - Clamp sub-pixel borders accounting for zoom

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22225 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22225
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

Clamp sub-pixel borders accounting for zoom

A previous patch added clamping for sub-pixel borders to ensure they
did not round to zero size. The change was done in paint code, leaving
the borders as sub-pixel sized in layout. The code prior to that patch
clamped the borders during style conversion but did not account for zoom,
meaning borders disappeared under zoom.

This change removes the clamping in paint and reverts to clamping in the
style conversion code, only this time accounting for zoom when considering
whether to clamp or not. This will prevent borders growing too large as
content is made larger, while preventing sub-pixel borders from disappearing
as content is made smaller.

Design Doc: https://docs.google.com/document/d/1fAYkOFxp2Luh6OOoXxtwOehmvNRGNss58ibQtVXL0Tw/edit?usp=sharing

Bug: 763402, 834489
Change-Id: Iba2ae80b0a981736b93453c1058fd586ba10212c
Reviewed-on: https://chromium-review.googlesource.com/2097514
WPT-Export-Revision: 918cfd220371dce9755a7b00765ceb538b1ced5e

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/384a60fa4407
[wpt PR 22225] - Clamp sub-pixel borders accounting for zoom, a=testonly

https://hg.mozilla.org/mozilla-central/rev/384a60fa4407

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.