1622138 - [wpt-sync] Sync PR 22230 - Make computedStyleMap return the computed value for lineHeight

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 22230 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22230
Details from upstream follow.

George Steel <[e-mail]> wrote:

Make computedStyleMap return the computed value for lineHeight

It previously returned the resolved value as produced by
ValueForLineHeight (this property is unique in that the computed and
resolved values differ even without a layout object).
Introduce another serializer ComputedValueForLineHeight which produces
the actual computed value.

Change-Id: Ic27d9a4fe7c67cbbb577ec4e4efed14a88a846c9
Reviewed-on: https://chromium-review.googlesource.com/2101858
WPT-Export-Revision: c2577edbae71184b3b293af156bd05e8cc66f4f2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=00200b90e274c2ff5433a3d59719d7a2574827e9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 47 tests

Status Summary

Firefox

PASS : 46
ERROR: 1

Chrome

OK : 1
PASS : 9
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/the-stylepropertymap/properties/line-height.html: ERROR (Chrome: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42881b0536f8
[wpt PR 22230] - Make computedStyleMap return the computed value for lineHeight, a=testonly

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/42881b0536f8