1622240 - Dark Theme - warning_text from Forget history menu - hard to read

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Cristian Fogel [:cfogel]]

Attachment: warnD.png

Affected versions

• 74.0, 75.0b3, 76.0a1 (2020-03-12);

Affected platforms

• Windows 10, macOS 10.13, Ubuntu 16.04;

Steps to reproduce

1. Launch Firefox, click on the 3line/Hambourger menu button;
2. Click on the Customize button;
3. Change to Dark Theme and Drag the Forget button on the bar(anywhere to be visible);
4. Exit the customize mode and click on the Forget button;

Expected result

• text in the menu is readable;

Actual result

• warning dark-red text on grey background is hard to read;

Regression range

• most likely not a regression, but will check asap;

Additional notes

• attached screenshot with the issue.

Comment 1

[abodenlosz]

• Regression range:
• Last good: 2018-04-08
• First bad: 2018-04-09
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4bc6b2401738b78fd47127a4c716bb9178e1a09&tochange=0528a414c2a86dad0623779abde5301d37337934

Comment 2

[Cristian Fogel [:cfogel]]

1451947 looks like the most likely candidate.
@Ntim, can confirm when available.

Comment 3

[Tim Nguyen :ntim]

Sounds like we can go with a similar fix as bug 1530632.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1622240 - Brighten the warning text in the Forget panel so it works with both light and dark backgrounds. r?ntim

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b402b1fab2
Brighten the warning text in the Forget panel so it works with both light and dark backgrounds. r=ntim

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/46b402b1fab2

Comment 7

[Cristian Fogel [:cfogel]]

Verified with 76.0a1 (2020-03-22), while an improvment is noticed it's still hard to the eyes.
Any chance this color can be changed to an even lighter one, or even white for dark theme?

• or bold/shadow.

Comment 8

[Tim Nguyen :ntim]

(In reply to Cristian Fogel, QA [:cfogel] from comment #7)

Verified with 76.0a1 (2020-03-22), while an improvment is noticed it's still hard to the eyes.
Any chance this color can be changed to an even lighter one, or even white for dark theme?

• or bold/shadow.

I filed bug 1623678 for this.

Comment 9

[abodenlosz]

• Regression range:
• Last good: 2018-04-08
• First bad: 2018-04-09
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4bc6b2401738b78fd47127a4c716bb9178e1a09&tochange=0528a414c2a86dad0623779abde5301d37337934

Comment 10

[Cristian Fogel [:cfogel]]

Awesome, will start tracking that bug then.
Thank you!