Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_selectpopup_colors.js
Categories
(Firefox :: General, enhancement, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: prathiksha, Assigned: shaynajustus, Mentored)
Details
Attachments
(1 file)
This is a good first bug for newcomers to Firefox development.
BrowserTestUtils.waitForCondition in browser_selectpopup_colors.js[0] can be replaced by TestUtils.waitForCondition.
You can run this test with the ./mach test command:
./mach test browser/base/content/test/forms/browser_selectpopup_colors.js
Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.
Hi! I'm an Outreachy applicant and I would like to be assigned this bug. Thanks!
|
Reporter | |
Updated•4 years ago
|
Hi! I made my changes and committed them, but I'm having a hard time pushing the code to Phabricator. When I used the "moz-phab submit" command in tells me to run "moz-phab install-certificate" (I guess somehow I missed this set earlier) and when it directs me to the Phabricator instance to get the API key it asks me to log in and then tells me I should set up Two-Factor Authentication. I didn't see anything about that in the documentation--what should I do next? Did I miss something when setting up Bugzilla and Phabricator?
|
|
Reporter | |
Comment 3•4 years ago
|
||
(In reply to Shayna from comment #2)
Hi! I made my changes and committed them, but I'm having a hard time pushing the code to Phabricator. When I used the "moz-phab submit" command in tells me to run "moz-phab install-certificate" (I guess somehow I missed this set earlier) and when it directs me to the Phabricator instance to get the API key it asks me to log in and then tells me I should set up Two-Factor Authentication. I didn't see anything about that in the documentation--what should I do next? Did I miss something when setting up Bugzilla and Phabricator?
Hi Shayna, you need to setup two factor auth using Google Authenticator. See https://wiki.mozilla.org/BMO/UserGuide/Two-Factor_Authentication#Configure_2FA:_TOTP_.28Google_Authenticator.29 for more details :)
Thank you! I got it working and submitted my code for review.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Oh interesting, I think my Prettier settings took over. I didn't realized that code got change and Prettier kept reverting it back -- disabled Prettier, so hopefully no more weird code changes. I amended my last commit and re-pushed the code to Phabricator. I hope I did that all correctly and you can see my changes?
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4fcbb1351c68 Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_selectpopup_colors.js r=prathiksha
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Description
•