1622274 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_temporary_permissions_navigation.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[:prathiksha]

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser_temporary_permissions_navigation.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/permissions/browser_temporary_permissions_navigation.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/source/browser/base/content/test/permissions/browser_temporary_permissions_navigation.js

Comment 1

[aleja533]

I want to work on this bug

Comment 2

[aleja533]

I run the test and it's pass. Now what would be the next step?

Comment 3

[:prathiksha]

(In reply to aleja533 from comment #2)

I run the test and it's pass. Now what would be the next step?

So the test is expected to pass with or without changing BrowserTestUtils to TestUtils. This good-first-bug is more of a task of cleaning up something in the code. The intent is to get beginners acquainted with creating patches, the setup, reviews, Mercurial, running tests, etc. You need to replace BrowserTestUtils with TestUtils in your patch as explained in the bug description.

Comment 4

[Johann Hofmann [:johannh]]

Did you mean to close this? I don't think so. Your next step would be to make the suggested changes and submit a patch. :)

Comment 5

[aleja533]

Attachment: Bug 1622274 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_temporary permissions navigation.js. r=prathiksha

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2092cd5fe532
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_temporary permissions navigation.js. r=prathiksha

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2092cd5fe532