Use AutoApplyAsyncTestAttributes in GetVisibleRect
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(2 files)
|
Assignee | |
Comment 1•4 years ago
|
||
The code in GetVisibleRect() uses the test scroll offset, but not the test zoom.
Using AutoApplyAsyncTestAttributes automatically uses both.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D66956
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49befaabfdbb Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r=botond https://hg.mozilla.org/integration/autoland/rev/1e89ecc6316f Propagate some proof-of-lock. r=botond
Backout by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04b274b47490 Backed out 2 changesets for causing multiple reftest failures.
|
|
Assignee | |
Comment 5•4 years ago
|
||
Argh. Using AutoApplyAsyncTestAttributes introduces a call to SampleCompositedAsyncTransform (via the ApplyAsyncTestAttributes function) which acquires the mRecursiveMutex again. This causes an out-of-order recursive acquire inside the checkerboard lock, leading to deadlock warnings. I should be able to fix it by propagating the proof-of-lock into SampleCompositedAsyncTransform.
|
||
Comment 6•4 years ago
|
||
Backed out 2 changesets for causing multiple reftest failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/04b274b47490ecff137aed349073244f8cd69332
Failure logs:
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293355885&repo=autoland&lineNumber=4526
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356991&repo=autoland&lineNumber=13967
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356431&repo=autoland&lineNumber=13953
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356453&repo=autoland&lineNumber=11070
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356387&repo=autoland&lineNumber=6993
- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356533&repo=autoland&lineNumber=4440
|
|
Assignee | |
Comment 7•4 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/351e6628fb79 Propagate some proof-of-lock. r=botond https://hg.mozilla.org/integration/autoland/rev/1e6455b73f28 Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r=botond
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/351e6628fb79
https://hg.mozilla.org/mozilla-central/rev/1e6455b73f28
Description
•