Closed Bug 1622395 Opened 9 months ago Closed 8 months ago

Use AutoApplyAsyncTestAttributes in GetVisibleRect

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(2 files)

The code in GetVisibleRect() uses the test scroll offset, but not the test zoom.
Using AutoApplyAsyncTestAttributes automatically uses both.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49befaabfdbb
Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r=botond
https://hg.mozilla.org/integration/autoland/rev/1e89ecc6316f
Propagate some proof-of-lock. r=botond
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04b274b47490
Backed out 2 changesets for causing multiple reftest failures.

Argh. Using AutoApplyAsyncTestAttributes introduces a call to SampleCompositedAsyncTransform (via the ApplyAsyncTestAttributes function) which acquires the mRecursiveMutex again. This causes an out-of-order recursive acquire inside the checkerboard lock, leading to deadlock warnings. I should be able to fix it by propagating the proof-of-lock into SampleCompositedAsyncTransform.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/351e6628fb79
Propagate some proof-of-lock. r=botond
https://hg.mozilla.org/integration/autoland/rev/1e6455b73f28
Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r=botond
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.