1622395 - Use AutoApplyAsyncTestAttributes in GetVisibleRect

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Followup from https://phabricator.services.mozilla.com/D66426?id=242759#inline-397231

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1622395 - Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r?botond

The code in GetVisibleRect() uses the test scroll offset, but not the test zoom.
Using AutoApplyAsyncTestAttributes automatically uses both.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1622395 - Propagate some proof-of-lock. r?botond

Depends on D66956

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49befaabfdbb
Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r=botond
https://hg.mozilla.org/integration/autoland/rev/1e89ecc6316f
Propagate some proof-of-lock. r=botond

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04b274b47490
Backed out 2 changesets for causing multiple reftest failures.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Argh. Using AutoApplyAsyncTestAttributes introduces a call to SampleCompositedAsyncTransform (via the ApplyAsyncTestAttributes function) which acquires the mRecursiveMutex again. This causes an out-of-order recursive acquire inside the checkerboard lock, leading to deadlock warnings. I should be able to fix it by propagating the proof-of-lock into SampleCompositedAsyncTransform.

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 2 changesets for causing multiple reftest failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/04b274b47490ecff137aed349073244f8cd69332

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=e87acf21935d5ff91c3e9dafe554a314ad31fd2b&searchStr=reftest&failure_classification_id=2&fromchange=911385b3cbc028a6b86ab884ca7955b4aaaa9898

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293355885&repo=autoland&lineNumber=4526
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356991&repo=autoland&lineNumber=13967
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356431&repo=autoland&lineNumber=13953
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356453&repo=autoland&lineNumber=11070
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356387&repo=autoland&lineNumber=6993
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293356533&repo=autoland&lineNumber=4440

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Try with fixes: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=d578906632d7f344c37187c9498dfab2a5a79ffe

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/351e6628fb79
Propagate some proof-of-lock. r=botond
https://hg.mozilla.org/integration/autoland/rev/1e6455b73f28
Use AutoApplyAsyncTestAttributes instead of manually doing a half-job. r=botond

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/351e6628fb79
https://hg.mozilla.org/mozilla-central/rev/1e6455b73f28