1622444 - Intermittent TV gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | subframe should be layerized at this point

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=293100962&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Kx30nfQWQfy261DOBVdkYg/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Kx30nfQWQfy261DOBVdkYg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 19 INFO TEST-START | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - Buffered messages logged at 20:34:52
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 20 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | Starting subtest helper_checkerboard_apzforcedisabled.html
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 21 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | expected at least one nonempty paint
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - Buffered messages finished
[task 2020-03-13T20:35:00.962Z] 20:35:00 WARNING - 22 INFO TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | subframe should be layerized at this point
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:299:16
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - spawnTest/w.ok@gfx/layers/apz/test/mochitest/apz_test_utils.js:422:32
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - test@gfx/layers/apz/test/mochitest/helper_checkerboard_apzforcedisabled.html:22:5
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - driveTest@gfx/layers/apz/test/mochitest/apz_test_utils.js:634:36
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 23 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | subframe should have a scroll id
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 24 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | expected at least one nonempty paint
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 25 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | expected string of form (x,y,w,h)
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 26 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | root element should have a displayport
[task 2020-03-13T20:35:00.962Z] 20:35:00 INFO - 27 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | root element should have at least 500px of vertical displayport margin
[task 2020-03-13T20:35:00.963Z] 20:35:00 INFO - 28 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | document got scrolled instantly
[task 2020-03-13T20:35:00.963Z] 20:35:00 INFO - 29 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | subframe is not checkerboarding
[task 2020-03-13T20:35:00.963Z] 20:35:00 INFO - 30 INFO TEST-PASS | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | helper_checkerboard_apzforcedisabled.html | Found the checkerboarding subframe
[task 2020-03-13T20:35:00.963Z] 20:35:00 INFO - 31 INFO TEST-OK | gfx/layers/apz/test/mochitest/test_group_checkerboarding.html | took 847ms

Comment 1

[Razvan Maries]

Kartikaya, could you take a look?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Test seems to pass on Android in non-verify mode. Not sure what's causing the verify mode failure but I can take a closer look.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Initial glance looks like it's a bug in isLayerized since the subframe is in fact layerized (it has a scroll id) and the rest of the test passes. I'll need to dump the APZ test data on a failing run to get any further. The failure happens on the third invocation of the test as part of the verify suite; the first two pass fine.

Comment 4

[Intermittent Failures Robot]

4 failures in 5336 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• mozilla-central: 1
• try: 1

Platform breakdown:

• android-em-7-0-x86_64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622444&startday=2020-03-09&endday=2020-03-15&tree=all

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Reproduced on try: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293344632&repo=try&lineNumber=2129

The logcat for that run shows content-side APZ data that indicates the scrollframe has NOT been layerized, or at least we haven't gotten a paint that includes the layerization. I think what's actually happening is that the waitForPaints just before happens too soon after the synthesizeClick, because on Android the click synthesization goes through the java UI thread and can take longer than it does on desktop. So we should probably make that synthesizeClickAndWaitForClickEvent or similar.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=bfdc0331b37fcfd2784d77eafed7974bd1c3964a has the fix and it looks green

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1622444 - Ensure the isLayerized check passes consistently on Android. r?botond

If we don't wait for the click event before checking for the layerization,
then the layerization may not actually have happened at the time of the check.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/949b07cf33b0
Ensure the isLayerized check passes consistently on Android. r=botond

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/949b07cf33b0