1622457 - title line of "Library", "Show All Bookmarks -> Downloads" has clear downloads to the far right

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[George R. Goffe]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

ctrl+shift+o produces a popup titled "Library" (show all bookmarks). For the downloads widget, the next line down in the display has buttons that ought to be together and NOT at the far end of the widget.

I have long file names and as a result, my "library" widget is3/4 the screen in size. The clear downloads button at the far right should be next to the organize button, followed by the search "button".

Actual results:

see above

Expected results:

see above

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marco Bonardo [:mak]]

Hm, I suspect bug 1443901 regressed this by ignoring the insertbefore="libraryToolbarSpacer" attribute.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1622457 - Restore the Clear Downloads button position in the Library window. r=standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/198254996baa
Restore the Clear Downloads button position in the Library window. r=Standard8

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/198254996baa

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2020-03-13) on Ubuntu 18.04 x64.
I retested everything using latest Nightly 77.0a1 and Firefox 76.0b4 on macOS 10.11, Ubuntu 18.04 x64 and Windows 10 x64. The issue is not reproducing anymore.