lowhashtest: broken argument parsing
Categories
(NSS :: Test, defect, P1)
Tracking
(Not tracked)
People
(Reporter: hpj, Assigned: hpj)
Details
Attachments
(1 file)
|
1.00 KB,
patch
|
kjacobs
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0
Steps to reproduce:
Ran all tests in FIPS mode.
Actual results:
lowhashtest reported that all hash functions failed. This happened because it was being called once per hash function with the name of the function to test as its first argument.
Due to bugs in the argument parsing, it would test every function regardless of arguments and report a failure if any one of them failed, resulting in disabled functions (MD5...) erroneously disqualifying runs that were only supposed to test a different function.
Expected results:
If a hash function is specified on the command line, that hash function should be tested instead of all of them. In FIPS mode that means only disabled hash functions would fail instead of all of them.
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Comment 1•4 years ago
|
||
Comment on attachment 9133395 [details] [diff] [review] nss-lowhashtest-fixes.patch Thank you!
|
|
||
Comment 2•4 years ago
|
||
Description
•