1622656 - the 'empty' method should be used to check for emptiness instead of 'size'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1622653 +++

Filling as a good first bug to learn workflows.

if (r.size() < 1) {
should use .empty() instead

https://searchfox.org/mozilla-central/source/security/manager/ssl/OSKeyStore.cpp#92

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Chanhee Cho]

Attachment: Bug 1622656 - OSKeyStore.cpp: replace r.size()<1 to r.empty(). r?Sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b87fcc141628
OSKeyStore.cpp: replace r.size()<1 to r.empty(). r=sylvestre

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b87fcc141628