Closed Bug 1622656 Opened 4 months ago Closed 2 months ago

the 'empty' method should be used to check for emptiness instead of 'size'

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
minor

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: Sylvestre, Assigned: channy1413, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1622653 +++

Filling as a good first bug to learn workflows.

if (r.size() < 1) {
should use .empty() instead

https://searchfox.org/mozilla-central/source/security/manager/ssl/OSKeyStore.cpp#92

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Mentor: sledru
Keywords: good-first-bug
Whiteboard: [lang=C++]
Assignee: nobody → channy1413
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b87fcc141628
OSKeyStore.cpp: replace r.size()<1 to r.empty(). r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.