Closed Bug 1622666 Opened 4 years ago Closed 4 years ago

IdentityCryptoService.cpp: redundant access specifier has the same accessibility as the previous access specifier

Categories

(Developer Infrastructure :: Source Code Analysis, task)

task
Not set
minor

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: Sylvestre, Assigned: amogh532516, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

private:
  SignRunnable(const SignRunnable&) = delete;

redundant access specifier has the same accessibility as the previous access specifier
here, protected is declared twice

https://searchfox.org/mozilla-central/source/services/crypto/component/IdentityCryptoService.cpp#99-115

As the change is trivial, it is just to learn how to contribute to Firefox.

http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-access-specifiers.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Depends on D67739

Assignee: nobody → amogh532516
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c493a010f75
Removes redundant access specifier r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: