1622673 - nsCellMap.cpp: converting integer literal to bool, use bool literal instead

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

  while (1) {

converting integer literal to bool, use bool literal instead
should be true

https://searchfox.org/mozilla-central/source/layout/tables/nsCellMap.cpp#2469

As the change is trivial, it is just to learn how to contribute to Firefox.

http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Atharva Raykar]

Attachment: Bug 1622673 - Converting integer literal to bool literal. r=dbaron

Comment 2

[Atharva Raykar]

Hi, new contributor here.

I have followed the procedures to the best of my understanding, and submitted a patch: https://phabricator.services.mozilla.com/D66960

I have tagged dbaron based on the commit messages in the log. I have also not tested against the try server, as I do not have level access 1 yet, and I felt this change was trivial enough that I could go without it for this patch.

I would love to know how to get another contributor to vouch for me, so I can work towards making more substantial contributions in the future.

Do inform me if I need to change anything.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68b5bfbd0a89
Converting integer literal to bool literal. r=dbaron

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/68b5bfbd0a89