nsCellMap.cpp: converting integer literal to bool, use bool literal instead
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: raykar.ath, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
while (1) {
converting integer literal to bool, use bool literal instead
should be true
https://searchfox.org/mozilla-central/source/layout/tables/nsCellMap.cpp#2469
As the change is trivial, it is just to learn how to contribute to Firefox.
http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Hi, new contributor here.
I have followed the procedures to the best of my understanding, and submitted a patch: https://phabricator.services.mozilla.com/D66960
I have tagged dbaron based on the commit messages in the log. I have also not tested against the try server, as I do not have level access 1 yet, and I felt this change was trivial enough that I could go without it for this patch.
I would love to know how to get another contributor to vouch for me, so I can work towards making more substantial contributions in the future.
Do inform me if I need to change anything.
Comment 4•5 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•