1622676 - dom/base: Make it flake8 compliant

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

As the change is easy, it is mostly to learn how to contribute to Firefox.

To work on this, remove this line:
https://searchfox.org/mozilla-central/source/.flake8#7

To run the linter:
$ ./mach lint -l flake8 dom/base

To run the autofix:
$ ./mach lint -l flake8 --fix dom/base/

Then, the remaining thing should be fixed by hand.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Pascal]

Line 7 was already uncommented in my flake8 file.
The linter says there's 0 problem in my repository.

Am I missing something?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Hello Pascal,

Sorry, I meant remove, not uncomment.
I can still see it on https://hg.mozilla.org/mozilla-central/file/tip/.flake8

Comment 3

[Pascal]

Attachment: Bug 1622676 - flake8 compliance. r=boris

Removing unused libraries

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 5

[akshita gupta]

Attachment: Bug 1622676 - Made dom/base flake8 compliant.r?championshuttler

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66198fe5af21
Made dom/base flake8 compliant.r=championshuttler,sylvestre

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/66198fe5af21