162268 - Reflow with table + fieldset every time a <input type="submit"> is clicked

Status: RESOLVED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Tobias Burnus]

This is Mozilla 1.1b; Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1b)
Gecko/20020809.

I have a <fieldset> which is embedded in <table>. If the window width is smalle
than the maximum size needed, then the formset size shrinks causing a reflow
every time I click 'submit'. (If I cancel the submit by moving the mouse cursor
out of the button I can repeat this several times)

Testcase + instruction to come.

Comment 1

[Tobias Burnus]

Attachment: Testcase with instructions

Comment 2

[Boris Zbarsky [:bzbarsky]]

To layout.  This is not submission.

Comment 3

[Marcus Campbell]

-> Layout (per comment #2)

Comment 4

[Boris Zbarsky [:bzbarsky]]

reassign for real

Comment 5

[Boris 'pi' Piwinger]

Dupe of bug 149734?

pi

Comment 6

[Kevin McCluskey (gone)]

-> jkeiser

Comment 7

[Daniel Wang]

*** Bug 208855 has been marked as a duplicate of this bug. ***

Comment 8

[Scott MacVicar]

I had a look at this bug and the best I could get without getting confused was

/layout/html/forms/src/nsFieldSetFrame.cpp line #475~

The call to ReflowChild returns a different value for kidDesiredSize.width, I'm
presuming that this ends up with the wrong MEW being reported to the parent.

I tried bz's patch in http://bugzilla.mozilla.org/show_bug.cgi?id=129346 just in
case.

Comment 9

[Jonathan Buchanan]

Attachment: Testcase exhibiting fieldset growth

User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0

I think the behaviour exhibited by this test case fits this bug - the fieldset
will expand if you change the selected option or click on the button (which
causes expansion on both mousedown and mouseup). On my machine, this expansion
only happens twice, after which the width of the table cell containing "Cell 2"
has become as small as possible.

This behaviour doesn't occur if:
- You don't specify a width for the table.
or
- You specify a width for the fieldset in pixels.

Comment 10

[Bernd]

This is wfm with a current trunk build winxp 2004111204.

Jonathan could you please retest with a current trunk build. ( I think, I did
fix this on trunk)

Comment 11

[Jonathan Buchanan]

Retested with trunk build 2004111904 on winxp.

It does appear to be fixed - both test cases wfm.

Comment 12

[Scott MacVicar]

Definately fixed on trunk.

Comment 13

[Mats Palmgren (inactive)]

WFM, 2004-12-29-05 trunk Linux.

-> WORKSFORME