HAR builder uses non standard fields for cache data
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(Not tracked)
People
(Reporter: Honza, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
HAR builder is currently exporting cache data under non standard fields (not in the spec)
http://www.softwareishard.com/blog/har-12-spec/#cache
Here is where the HAR build code lives:
https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/devtools/client/netmonitor/src/har/har-builder.js#457
Here is IDL for nsICacheEntryInfo:
https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/netwerk/cache/nsICacheVisitor.idl#77
We should rename:
lastFetched
=>lastAccess
fetchCount
=>hitCount
HAR Importer needs to be also updated (and keep backward compatibility for already exported files)
Further the Cache panel needs to be updated and use the new fields:
https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/devtools/client/netmonitor/src/components/request-details/CachePanel.js#108-127
Finally we need to update related tests:
- https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/devtools/client/netmonitor/src/har/test/browser_net_har_import.js#7
- https://searchfox.org/mozilla-central/rev/3f8c67d7fd836d559491e3fe497bc739f707c1a6/devtools/client/netmonitor/src/har/test/browser_net_har_copy_all_as_har.js#7
Those tests should make sure we are copying and importing cache data properly.
Honza
Comment 1•4 years ago
|
||
Can I also work on this, I have fixed the other har issues and submitted the patch, also this is an independent bug? or It depends on invalid title one?
Reporter | ||
Comment 2•4 years ago
|
||
I think that we should land bug 1616244 first but, I think that you can already start working on this one.
Honza
Comment 3•4 years ago
|
||
Comment 4•4 years ago
|
||
Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3
(Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3
(normal.)
Description
•