Closed Bug 1622787 Opened 4 years ago Closed 4 years ago

Detect abi using ro.product.cpu.abi, ro.product.cpu.abilist and the apk

Categories

(Testing :: XPCShell Harness, enhancement, P2)

Version 3
enhancement

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: bc, Assigned: bc)

Details

Attachments

(1 file)

Currently, remotexpcshelltest.py uses ro.vendor.product.cpu.abi to set MOZ_ANDROID_CPU_ABI but this fails on Android 10 where ro.vendor.product.cpu.abi does not exist.

For my Pixel2 running Android 10 I see

$ adb shell getprop | grep ro.vendor.product.cpu.abi 
[ro.vendor.product.cpu.abilist]: [arm64-v8a,armeabi-v7a,armeabi]
[ro.vendor.product.cpu.abilist32]: [armeabi-v7a,armeabi]
[ro.vendor.product.cpu.abilist64]: [arm64-v8a]

Failing to set MOZ_ANDROID_CPU_ABI properly means we crash on start up and can not test at all.

Summary: Detect abi using ro.vendor.product.cpu.abi, ro.vendor.product.cpu.abilist and the apk → Detect abi using ro.product.cpu.abi, ro.product.cpu.abilist and the apk
Attachment #9133547 - Attachment description: Bug 1622787 - In android xpcshell-test use ro.vendor.product.cpu.abi, ro.vendor.product.cpu.abilist and the apk to determine the appropriate abi, r=gbrown. → Bug 1622787 - In android xpcshell-test use ro.product.cpu.abi, ro.product.cpu.abilist and the apk to determine the appropriate abi, r=gbrown.
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/016171a0b8c1
In android xpcshell-test use ro.product.cpu.abi, ro.product.cpu.abilist and the apk to determine the appropriate abi, r=gbrown.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: